Page MenuHomePhabricator

Replace `addWikiText( $this->msg(....)->text() )`
Open, Needs TriagePublic

Description

The documentation for OutputPage::addWikiMsg(...) seems to indicate that the proper form is:

addWikiText( $this->msg(....)->plain() )

but a bunch of places seem to use:

addWikiText( $this->msg(....)->text() )

This double-expansion is probably harmless, but these should probably be changed to use ->plain() or (even better) addWikiMsg(...) instead.

Event Timeline

cscott created this task.Oct 9 2018, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2018, 8:33 PM
cscott updated the task description. (Show Details)Oct 11 2018, 12:33 PM

Change 466592 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466592

Change 466597 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FlaggedRevs@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466597

Change 466601 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ArticlePlaceholder@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466601

Change 466605 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ConfirmEdit@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466605

Change 466605 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466605

Change 466592 merged by jenkins-bot:
[mediawiki/core@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466592

Change 466601 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466601

Change 466597 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Only expand {{...}} in messages once

https://gerrit.wikimedia.org/r/466597

Change 469001 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WikiLexicalData@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469001

Change 469007 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/LinkedWiki@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469007

Change 469001 merged by jenkins-bot:
[mediawiki/extensions/WikiLexicalData@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469001

Change 469017 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/AdManager@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469017

Change 469022 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Cargo@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469022

Change 469024 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PageForms@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469024

Change 469017 merged by jenkins-bot:
[mediawiki/extensions/AdManager@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469017

Change 469022 abandoned by Yaron Koren:
Replace deprecated untidy OutputPage::addWikiText() method

Reason:
I checked in a corresponding change: https://gerrit.wikimedia.org/r/469454 Thanks for your help!

https://gerrit.wikimedia.org/r/469022

Change 469935 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Only expand {{...}} in messages once (part 2)

https://gerrit.wikimedia.org/r/469935

Change 469951 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/OAuth@master] Replace deprecated OutputPage::parseInline()

https://gerrit.wikimedia.org/r/469951

Change 469951 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Replace deprecated OutputPage::parseInline()

https://gerrit.wikimedia.org/r/469951

Change 469935 merged by jenkins-bot:
[mediawiki/core@master] Only expand {{...}} in messages once (part 2)

https://gerrit.wikimedia.org/r/469935

Change 469024 abandoned by C. Scott Ananian:
Replace deprecated untidy OutputPage::addWikiText() method

Reason:
Abandoned in favor of Yaron's own version.

https://gerrit.wikimedia.org/r/469024

Change 469007 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/LinkedWiki@master] Replace deprecated untidy OutputPage::addWikiText() method

https://gerrit.wikimedia.org/r/469007