Page MenuHomePhabricator

Flow\Tests\Formatter\FormatterTest test failures: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given
Open, Needs TriagePublic

Description

1) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #0 ('With only a topicId reply sho...t fail', Closure Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), null)
TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given, called in /var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/AbstractFormatter.php on line 309

/var/www/wiki/mediawiki/core/includes/linker/LinkRenderer.php:144
/var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/AbstractFormatter.php:309
/var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

2) Flow\Tests\Formatter\FormatterTest::testCheckUserFormatter with data set #1 ('With topicId and postId shoul...t fail', Closure Object (...), 'reply', Flow\Model\UUID Object (...), Flow\Model\UUID Object (...), Flow\Model\UUID Object (...))
TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given, called in /var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/AbstractFormatter.php on line 309

/var/www/wiki/mediawiki/core/includes/linker/LinkRenderer.php:144
/var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/AbstractFormatter.php:309
/var/www/wiki/mediawiki/extensions/Flow/includes/Formatter/CheckUserFormatter.php:50
/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Formatter/FormatterTest.php:76
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

Event Timeline

Reedy created this task.Oct 9 2018, 11:14 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 9 2018, 11:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Are you seeing this locally or in CI?

Assuming that T207578 is a duplicate; half of T207616 is also a duplicate

Aklapper renamed this task from Flow\Tests\Formatter\FormatterTest test failures to Flow\Tests\Formatter\FormatterTest test failures: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given.
Aklapper added a subscriber: RazeSoldier.

Change 472263 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472263 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472263

Change 472456 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@REL1_32] Temporarily mark flaky tests as broken

https://gerrit.wikimedia.org/r/472456

Change 472456 abandoned by Kosta Harlan:
Temporarily mark flaky tests as broken

Reason:
No comments/activity on this so I assume it's not needed anymore.

https://gerrit.wikimedia.org/r/472456