Page MenuHomePhabricator

Nominated for deletion filter disregards the current article's state
Closed, ResolvedPublic

Description

Checked in testwiki.
If one of an article's revisions is nominated for deletion, the article will be always present in the PageTriage feed when 'Nominated for deletion' filter is selected even when the nomination for deletion is removed.

  1. Mark a page for deletion - with any tag for deletion via the curation toolbar or via Twinkle.
  1. The page will be fetched with the filter set - 'Reviewed/Unreviewed' and 'Nominated for deletion'. The trashbin icon is displayed indicating the article's nomination for deletion.

  1. A user deleted the added template and added some edits - the page state in db does not have traces of being nominated for deletion:

Example: in testwiki

select ptrpt_tag_id, ptrpt_value, ptrt_tag_name, ptrt_tag_desc   from pagetriage_page_tags join pagetriage_tags on ptrt_tag_id=ptrpt_tag_id  where  ptrpt_page_id=100935;
+--------------+-------------+-----------------+--------------------------------+
| ptrpt_tag_id | ptrpt_value | ptrt_tag_name   | ptrt_tag_desc                  |
+--------------+-------------+-----------------+--------------------------------+
|            1 | 0           | linkcount       | Number of inbound links        |
|            2 | 0           | category_count  | Category mapping count         |
|            3 | 0           | csd_status      | CSD status                     |
|            4 | 0           | prod_status     | PROD status                    |
|            5 | 0           | blp_prod_status | BLP PROD status                |
|            6 | 0           | afd_status      | AFD status                     |
|            7 | 4           | rev_count       | Number of edits to the article |
|            8 | 144         | page_len        | Number of bytes of article     |
+--------------+-------------+-----------------+--------------------------------+

But since the history of the page has a record of being proposed for deletion, it still is displayed with 'Nominated for deletion' filter:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 12:33 AM

Change 465618 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Handle page that are unnominated for deletion

https://gerrit.wikimedia.org/r/465618

SBisson claimed this task.Oct 10 2018, 12:59 PM
SBisson edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
SBisson moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

The 'nominated for deletion' filter is not based on any of the deletion tags but on the ptrp_deleted column of the pagetriage_page table. This field was correctly updated when a page becomes nominated for deletion but it was not correctly reset when a page is un-nominated. That's what the patch above fixes.

Change 465618 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Handle page that are unnominated for deletion

https://gerrit.wikimedia.org/r/465618

Change 465676 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.24] Handle page that are unnominated for deletion

https://gerrit.wikimedia.org/r/465676

Checked in betalabs - the pages were nominated for deletion with [[Category:All_articles_proposed_for_deletion]] (thx, @SBisson).
ptrp_deleted gets updated when the category is removed and 'Nominated for deletion' filter won't fetch it.

In betalabs the testing for 'Nominated for deletion' is rather limited - templates for PageTriage and Twinkle are not present. So, more testing after deployment is needed.

Change 465676 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.24] Handle page that are unnominated for deletion

https://gerrit.wikimedia.org/r/465676

Etonkovidova closed this task as Resolved.Oct 11 2018, 7:23 PM

Checked the fix after deployment - PageTriage nominating for deletion options and Twinkle options (specifically PROD). The pages's state is consistent with ptrp_deleted tag.

Reedy renamed this task from Nominated for deletion filter disregards the current article's state to Nominated for deletion filter disregards the current article's state.Oct 11 2018, 7:24 PM

@MMiller_WMF The fix was deployed to enwiki and I fixed the pages with inconsistent status.