Page MenuHomePhabricator

WatchedItemStore should not use MediaWikiServices internally
Closed, ResolvedPublic

Description

WatchedItemStore currently makes one called to the static MediaWikiServices in updateNotificationTimestamp

MediaWikiServices::getInstance()->getDBLoadBalancerFactory()

Instead this service should be injected.

In https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/464029/ it will be injected and then it should be a simple case of switching what that method does.

Event Timeline

Addshore created this task.Oct 10 2018, 8:17 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 10 2018, 8:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from WatchedItemStore uses MediaWikiServices internally to WatchedItemStore should not use MediaWikiServices internally.Oct 10 2018, 8:17 AM

Change 466717 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

https://gerrit.wikimedia.org/r/466717

Change 466717 merged by jenkins-bot:
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

https://gerrit.wikimedia.org/r/466717

Umherirrender closed this task as Resolved.Oct 12 2018, 10:25 PM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.