Page MenuHomePhabricator

WatchedItemStore should not use MediaWikiServices internally
Closed, ResolvedPublic


WatchedItemStore currently makes one called to the static MediaWikiServices in updateNotificationTimestamp


Instead this service should be injected.

In it will be injected and then it should be a simple case of switching what that method does.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from WatchedItemStore uses MediaWikiServices internally to WatchedItemStore should not use MediaWikiServices internally.Oct 10 2018, 8:17 AM

Change 466717 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

Change 466717 merged by jenkins-bot:
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.