Page MenuHomePhabricator
Create Task
Maniphest T206601

WatchedItemStore should not use MediaWikiServices internally
Closed, ResolvedPublic
Actions

Description

WatchedItemStore currently makes one called to the static MediaWikiServices in updateNotificationTimestamp

MediaWikiServices::getInstance()->getDBLoadBalancerFactory()

Instead this service should be injected.

In https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/464029/ it will be injected and then it should be a simple case of switching what that method does.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+93 -70Pass LBFactory to WatchedItemStore
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Oct 10 2018, 8:17 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 10 2018, 8:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from WatchedItemStore uses MediaWikiServices internally to WatchedItemStore should not use MediaWikiServices internally.Oct 10 2018, 8:17 AM
Addshore mentioned this in T206602: Move ReadOnlyMode and ConfiguredReadOnlyMode to wikimedia/rdbms.Oct 10 2018, 8:22 AM
gerritbot added a subscriber: gerritbot.Oct 11 2018, 7:12 PM

Change 466717 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

https://gerrit.wikimedia.org/r/466717

gerritbot added a project: Patch-For-Review.Oct 11 2018, 7:12 PM
gerritbot added a comment.Oct 12 2018, 9:48 PM

Change 466717 merged by jenkins-bot:
[mediawiki/core@master] Pass LBFactory to WatchedItemStore

https://gerrit.wikimedia.org/r/466717

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 12 2018, 10:00 PM
Umherirrender closed this task as Resolved.Oct 12 2018, 10:25 PM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL