Maniphest T206614

with a form error if they try to comment without an email set
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwalton9-WMF
	Oct 10 2018, 10:54 AM

Description

If you attempt to leave a comment on an application but don't have an email set on your account you are redirected to /comments/post/ with a 'this field is required' form validation error.

We should do something else here, either don't let people leave comments if they have no email set, provide them with more sensible feedback on the issue, or stop requiring email to leave comments.

Event Timeline

Samwalton9-WMF created this task.Oct 10 2018, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 10:54 AM

Samwalton9-WMF triaged this task as Medium priority.Oct 10 2018, 1:10 PM

Samwalton9-WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.

Samwalton9-WMF added a project: good first task.

Per discussion with @AVasanth_WMF, the last option is probably best, since users can already apply without an email.

• AVasanth_WMF claimed this task.Jan 17 2019, 12:51 PM

• AVasanth_WMF moved this task from Open tasks to Done on the Library-Card-Platform board.Jan 26 2019, 9:36 AM

• AVasanth_WMF closed this task as Resolved.Jan 31 2019, 4:23 PM

Don't send users to /comments/post/ with a form error if they try to comment without an email setClosed, ResolvedPublicActions

Description

Event Timeline

Don't send users to /comments/post/ with a form error if they try to comment without an email set
Closed, ResolvedPublic
Actions