Page MenuHomePhabricator

Constraints are not shown in IE11
Closed, ResolvedPublic3 Story Points

Description

IE11 doesn't support Object.assign(), which was apparently added to the constraints extension in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/460063/17/modules/gadget.js

When loading the page, an error about "assign" not being supported is printed to the console and no constraints are shown.

Event Timeline

Nikki created this task.Oct 10 2018, 3:54 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 10 2018, 3:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I haven’t looked into this in too much detail, but I suspect we can use jQuery.extend instead of Object.assign here and in T206644: Lexeme forms can't be added in IE11.

Addshore set the point value for this task to 3.Oct 16 2018, 1:11 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 16 2018, 1:49 PM

Change 471944 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use jQuery.extend instead of Object.assign

https://gerrit.wikimedia.org/r/471944

Change 471944 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use jQuery.extend instead of Object.assign

https://gerrit.wikimedia.org/r/471944