Page MenuHomePhabricator
Create Task
Maniphest T206650

subscr_modify messages lead to failmail
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

INVALID_RECURRING Msg not recognized as a recurring payment related message.

e.g. /damaged/62357, /damaged/62358

Details

SubjectRepoBranchLines +/-
Ignore subscr_modify messageswikimedia/fundraising/SmashPigmaster+74 -5
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Oct 10 2018, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 4:05 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 15 2018, 7:41 PM
Ejegg added a comment.Oct 17 2018, 3:07 PM

I notice that in the Civi code, the subscr_modify type is commented out, with the note that 'at the moment, we are not accepting modification messages, so this is currently unused.'

Guess we used to drop the messages in the listener, before we did the paypal job refactor. We can go back to dropping those for now and revisit them after big english.

Ejegg added a comment.Oct 17 2018, 3:44 PM

hmm, the commented-out code actually looks pretty decent. Might be OK to add a test and un-comment it. That might also solve T146309.

gerritbot subscribed.Oct 19 2018, 4:09 AM

Change 468500 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Ignore subscr_modify messages

https://gerrit.wikimedia.org/r/468500

gerritbot added a project: Patch-For-Review.Oct 19 2018, 4:09 AM
Ejegg claimed this task.Oct 19 2018, 4:11 AM
Ejegg triaged this task as Medium priority.
Ejegg set the point value for this task to 1.
Ejegg moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.
Ejegg added a project: Fundraising Sprint USB stands for underhanded socket bureaucracy.

Was easy to add this to the ignore list. Pulling into sprint to cut down on irrelevant failmail at this crucial time.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint USB stands for underhanded socket bureaucracy board.Oct 19 2018, 4:11 AM
gerritbot added a comment.Oct 19 2018, 7:09 PM

Change 468500 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Ignore subscr_modify messages

https://gerrit.wikimedia.org/r/468500

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint USB stands for underhanded socket bureaucracy board.Oct 19 2018, 7:12 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint USB stands for underhanded socket bureaucracy board.Oct 22 2018, 3:35 PM
Ejegg closed this task as Resolved.Oct 29 2018, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL