Page MenuHomePhabricator
Create Task
Maniphest T206675

1.33.0-wmf.21 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Release Version
1.33.0-wmf.21
Release Date
Mar 11 2019, 12:00 AM

2019 week 11 1.33-wmf.21 Changes wmf/1.33.0-wmf.21

This MediaWiki Train Deployment is scheduled for the week of Monday, March 11th:

Monday March 11thTuesday, March 12thWednesday, March 13thThursday, March 14thFriday
Backports only.Branch wmf.21 and deploy to Group 0 Wikis.Deploy wmf.21 to Group 1 Wikis.Deploy wmf.21 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.21 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.33.0-wmf.20
Next: 1.33.0-wmf.22
SubjectRepoBranchLines +/-
Drop use of getModuleScripts, empty and now hard-deprecatedmediawiki/extensions/ParsoidBatchAPIwmf/1.33.0-wmf.21+1 -1
Drop use of getModuleScripts, empty and now hard-deprecatedmediawiki/extensions/ParsoidBatchAPImaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasezeljkofilipinT206675 1.33.0-wmf.21 deployment blockers
 ResolvedPRODUCTION ERRORzeljkofilipinT218098 Call to a member function addJsConfigVars() on a non-object (null)
 DuplicatePRODUCTION ERRORNoneT218101 PHP Notice: Undefined variable: output

Event Timeline

greg created this task.Oct 10 2018, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 5:23 PM
greg triaged this task as Medium priority.Oct 10 2018, 7:26 PM
Liuxinyu970226 subscribed.Oct 27 2018, 8:50 AM
zeljkofilipin claimed this task.Mar 12 2019, 9:27 AM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptMar 12 2019, 9:27 AM
zeljkofilipin added a project: User-zeljkofilipin.Mar 12 2019, 9:27 AM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin added a comment.Mar 12 2019, 10:32 AM

Cutting the branch.

zeljkofilipin added a comment.Mar 12 2019, 1:33 PM

1.33.0-wmf.21 at group 0 (sal, gerrit, mediawiki).

zeljkofilipin added a subtask: T218098: Call to a member function addJsConfigVars() on a non-object (null).Mar 12 2019, 1:49 PM
zeljkofilipin added a subtask: T218101: PHP Notice: Undefined variable: output.Mar 12 2019, 2:02 PM
zeljkofilipin closed subtask T218098: Call to a member function addJsConfigVars() on a non-object (null) as Resolved.Mar 13 2019, 11:38 AM
zeljkofilipin added a comment.Mar 13 2019, 1:23 PM

1.33.0-wmf.21 at group 1 (sal, gerrit, mediawiki).

Jdforrester-WMF subscribed.Mar 13 2019, 4:32 PM
zeljkofilipin added a comment.Mar 14 2019, 1:15 PM

1.33.0-wmf.21 everywhere (sal, gerrit, mediawiki).

herron subscribed.Mar 14 2019, 4:05 PM

There looks to be a significant increase (about 1.5 million in the past hour) of log messages from the mediawiki "deprecated" channel to the effect of Use of ParserOutput::getModuleScripts was deprecated in MediaWiki 1.33. Could we squelch these somehow?

https://logstash.wikimedia.org/goto/209aa2ecdcad0527bba0081f33f339a2

Jdforrester-WMF added a comment.Mar 14 2019, 4:19 PM

Argh, caused by ParsoidBatchAPI which I didn't spot. Patch coming.

gerritbot subscribed.Mar 14 2019, 4:22 PM

Change 496483 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ParsoidBatchAPI@master] Drop use of getModuleScripts, empty and now hard-deprecated

https://gerrit.wikimedia.org/r/496483

gerritbot added a project: Patch-For-Review.Mar 14 2019, 4:22 PM
Aklapper added a comment.Mar 14 2019, 4:48 PM

I'm not sure yet what to make out of T218310: "Bad title" message when publishing page: "The requested page title contains invalid characters: "%D7"." (missing exact repro steps, how often it happens, etc) but mentioning it here, just in case.

gerritbot added a comment.Mar 14 2019, 5:39 PM

Change 496483 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@master] Drop use of getModuleScripts, empty and now hard-deprecated

https://gerrit.wikimedia.org/r/496483

gerritbot added a comment.Mar 14 2019, 5:39 PM

Change 496498 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ParsoidBatchAPI@wmf/1.33.0-wmf.21] Drop use of getModuleScripts, empty and now hard-deprecated

https://gerrit.wikimedia.org/r/496498

gerritbot added a comment.Mar 14 2019, 5:56 PM

Change 496498 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@wmf/1.33.0-wmf.21] Drop use of getModuleScripts, empty and now hard-deprecated

https://gerrit.wikimedia.org/r/496498

Stashbot subscribed.Mar 14 2019, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-14T17:59:34Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/ParsoidBatchAPI/includes/ApiParsoidBatch.php: Hot-deploy I2842dfea to reduce deprecation spam after T206675 deploy of wmf.21 (duration: 00m 49s)

Jdforrester-WMF added a comment.Mar 14 2019, 7:44 PM
In T206675#5024498, @herron wrote:

There looks to be a significant increase (about 1.5 million in the past hour) of log messages from the mediawiki "deprecated" channel to the effect of Use of ParserOutput::getModuleScripts was deprecated in MediaWiki 1.33. Could we squelch these somehow?

https://logstash.wikimedia.org/goto/209aa2ecdcad0527bba0081f33f339a2

That's now fixed, but the new glut of PasswordPolicyChecks::checkPopularPasswordBlacklist deprecations is a different thing which I'm looking at.

zeljkofilipin added a comment.Mar 15 2019, 1:31 PM
In T206675#5024650, @Aklapper wrote:

I'm not sure yet what to make out of T218310: "Bad title" message when publishing page: "The requested page title contains invalid characters: "%D7"." (missing exact repro steps, how often it happens, etc) but mentioning it here, just in case.

Looks like it's stalled, so I guess it's not blocking the train?

zeljkofilipin added a comment.Mar 15 2019, 1:33 PM
In T206675#5024498, @herron wrote:

There looks to be a significant increase (about 1.5 million in the past hour) of log messages from the mediawiki "deprecated" channel to the effect of Use of ParserOutput::getModuleScripts was deprecated in MediaWiki 1.33. Could we squelch these somehow?

https://logstash.wikimedia.org/goto/209aa2ecdcad0527bba0081f33f339a2

I was not aware of that dashboard. Should it be added to the list of things train conductor should be monitoring?

https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment/Train_deploys#Places_to_Watch_for_Breakage

zeljkofilipin added a comment.Mar 15 2019, 1:38 PM
In T206675#5025503, @Jdforrester-WMF wrote:

That's now fixed, but the new glut of PasswordPolicyChecks::checkPopularPasswordBlacklist deprecations is a different thing which I'm looking at.

Is there a task? (Could not find it.) Should it be added as a blocker?

IKhitron subscribed.Mar 15 2019, 1:46 PM
zeljkofilipin added subscribers: aaron, Catrope, Krinkle.EditedMar 15 2019, 1:47 PM

I'm not sure if this is a blocker: Wikitech-l: Unbreak now! problem in this week train Watchlist.

@Catrope said that it might be caused by 416198. cc @Krinkle @aaron

herron added a comment.Mar 15 2019, 1:52 PM
In T206675#5026999, @zeljkofilipin wrote:
In T206675#5024498, @herron wrote:

https://logstash.wikimedia.org/goto/209aa2ecdcad0527bba0081f33f339a2

I was not aware of that dashboard. Should it be added to the list of things train conductor should be monitoring?

https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment/Train_deploys#Places_to_Watch_for_Breakage

The logstash link above might be too specific since it only displays channel:deprecated, but I would say it is worthwhile to monitor overall log volumes for significant changes here https://grafana.wikimedia.org/d/000000102/production-logging

Jdforrester-WMF added a comment.Mar 15 2019, 3:12 PM
In T206675#5027002, @zeljkofilipin wrote:
In T206675#5025503, @Jdforrester-WMF wrote:

That's now fixed, but the new glut of PasswordPolicyChecks::checkPopularPasswordBlacklist deprecations is a different thing which I'm looking at.

Is there a task? (Could not find it.) Should it be added as a blocker?

T218359 -> T151425. No.

zeljkofilipin added a comment.Mar 15 2019, 3:22 PM
In T206675#5027019, @herron wrote:

The logstash link above might be too specific since it only displays channel:deprecated, but I would say it is worthwhile to monitor overall log volumes for significant changes here https://grafana.wikimedia.org/d/000000102/production-logging

Thanks for the link! Done!

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 17 2019, 3:04 AM
zeljkofilipin closed this task as Resolved.Mar 18 2019, 9:48 AM
Liuxinyu970226 unsubscribed.Mar 24 2019, 4:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL