Maniphest T206676

1.33.0-wmf.22 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	greg
	Oct 10 2018, 5:23 PM

Details

Release Version: 1.33.0-wmf.22
Release Date: Mar 18 2019, 12:00 AM

2019 week 12 1.33-wmf.22 Changes wmf/1.33.0-wmf.22

This MediaWiki Train Deployment is scheduled for the week of Monday, March 18th:

Monday March 18th	Tuesday, March 19th	Wednesday, March 20th	Thursday, March 21st	Friday
Backports only.	Branch `wmf.22` and deploy to Group 0 Wikis.	Deploy `wmf.22` to Group 1 Wikis.	Deploy `wmf.22` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.22 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.33.0-wmf.21

Next: 1.33.0-wmf.23

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	zeljkofilipin	T206676 1.33.0-wmf.22 deployment blockers
Duplicate		None	T218322 Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019)
Resolved		Nikerabbit	T218366 Fatal when logged in and looking at beta cluster
Resolved		Daimona	T218513 TypeError: this.setFlags is not a function preventing datetime fields from being loaded
Resolved		Krinkle	T91454 ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason
Resolved	Security	thcipriani	T218597 Work out how we are going to cut deploy branches without gerrit HTTP Token
Resolved		Jdforrester-WMF	T218694 fatal: Project not found: p/VisualEditor/VisualEditor
Resolved	PRODUCTION ERROR	Arlolra	T218817 PHP Warning: count(): Parameter must be an array or an object that implements Countable
Duplicate	PRODUCTION ERROR	None	T218825 PHP Fatal Error: Argument 1 passed to Wikibase\Rdf\RdfBuilder::addEntityRedirect() must be an instance of Wikibase\DataModel\Entity\EntityId, null given
Resolved		Jdforrester-WMF	T218830 selectandother widget broken, particular on Special:GlobalBlock since 1.33.0-wmf.22
Resolved		gabriel-wmde	T218722 DropdownInputWidget with MenuSectionOptionWidget triggers endless change events
Resolved	PRODUCTION ERROR	xSavitar	T218883 Bad value for parameter $s: must be a string
Resolved	PRODUCTION ERROR	• Petar.petkovic	T218902 Log spam: "User account is not global"
Duplicate		None	T218826 Old sitenotice showed up after three years
Resolved		daniel	T218918 Some interface messages (e.g. sitenotice, others) are loading old revisions of their messages
Resolved		daniel	T219042 Flaky test MessageCacheTest::testLoadFromDB_fetchLatestRevision
Invalid	PRODUCTION ERROR	Addshore	T218950 Fatal Error from SpecialEntityData.php: Argument 9 passed to EntityDataRequestHandler must be array

Event Timeline

greg created this task.Oct 10 2018, 5:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 5:23 PM

greg triaged this task as Medium priority.Oct 10 2018, 7:26 PM

Liuxinyu970226 subscribed.Oct 27 2018, 8:50 AM

zeljkofilipin added a project: User-zeljkofilipin.Mar 12 2019, 9:28 AM

zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.

Jdforrester-WMF subscribed.Mar 13 2019, 4:32 PM

dbarratt added a subtask: T218322: Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019).Mar 14 2019, 5:26 PM

Krenair added a subtask: T218366: Fatal when logged in and looking at beta cluster.Mar 14 2019, 10:30 PM

Etonkovidova closed subtask T218366: Fatal when logged in and looking at beta cluster as Resolved.Mar 15 2019, 8:36 PM

Daimona added a subtask: T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.Mar 17 2019, 3:02 PM

zeljkofilipin claimed this task.Mar 18 2019, 9:29 AM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptMar 18 2019, 9:29 AM

zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Mar 18 2019, 9:30 AM

zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.

Added T91454 to the blockers because of the extra care needed to roll it out:

In T91454#1939833, @Florian wrote:

Adding @greg and @mmodell because of the comment from @Anomie on the change: https://gerrit.wikimedia.org/r/#/c/264494/

From my perspective, the best solution would be:

Merge the change (https://gerrit.wikimedia.org/r/#/c/264494/) before next Tuesday (before the new wmf.11 branch was created)

Cherry pick the change to wmf.10 (https://gerrit.wikimedia.org/r/#/c/264591/)

While wmf.11 is deployed to group1 wikis at Wednesday, merge and swat deploy the cherry picked wmf.10 change to group2 (wikipedias)

s/wmf.11/wmf.22/ and s/wmf.10/wmf.21/

Anomie mentioned this in T91454: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason.Mar 18 2019, 8:56 PM

Jdforrester-WMF closed subtask T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded as Resolved.Mar 18 2019, 10:05 PM

Krinkle closed subtask T91454: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason as Resolved.Mar 19 2019, 2:26 AM

@greg T91454 has been resolved by @Krinkle, but I don't see it deployed. I've asked for clarification at T91454#5035445.

It's train time now, but it's delayed because Gerrit is down.

Cutting the branch.

zeljkofilipin added a subtask: T218694: fatal: Project not found: p/VisualEditor/VisualEditor.Mar 19 2019, 3:56 PM

• Mholloway subscribed.Mar 19 2019, 6:53 PM

In T206676#5036025, @zeljkofilipin wrote:

Cutting the branch.

The branch has not been cut because of T218694.

zeljkofilipin closed subtask T218597: Work out how we are going to cut deploy branches without gerrit HTTP Token as Resolved.Mar 20 2019, 12:02 AM

The branch is finally cut. Thanks to @thcipriani for all the help. There are no more blockers. It's too late to continue with the train. I will continue tomorrow.

zeljkofilipin added a subtask: T218783: `scap clean` failure.Mar 20 2019, 1:50 PM

Train is blocked on T218783.

greg removed a subtask: T218783: `scap clean` failure.Mar 20 2019, 4:13 PM

Group0 at 1.33.0-wmf.22 (gerrit, mediawiki, sal).

zeljkofilipin added a subtask: T218817: PHP Warning: count(): Parameter must be an array or an object that implements Countable.Mar 20 2019, 8:05 PM

Group1 at 1.33.0-wmf.22 (gerrit, mediawiki, sal).

zeljkofilipin added a subtask: T218825: PHP Fatal Error: Argument 1 passed to Wikibase\Rdf\RdfBuilder::addEntityRedirect() must be an instance of Wikibase\DataModel\Entity\EntityId, null given.Mar 20 2019, 9:15 PM

Bawolff added a subtask: T218830: selectandother widget broken, particular on Special:GlobalBlock since 1.33.0-wmf.22.Mar 20 2019, 10:47 PM

Jdforrester-WMF closed subtask T218830: selectandother widget broken, particular on Special:GlobalBlock since 1.33.0-wmf.22 as Resolved.Mar 20 2019, 11:50 PM

Arlolra closed subtask T218817: PHP Warning: count(): Parameter must be an array or an object that implements Countable as Resolved.Mar 21 2019, 1:07 AM

Addshore mentioned this in T218826: Old sitenotice showed up after three years.Mar 21 2019, 9:55 AM

hashar mentioned this in T218860: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed..Mar 21 2019, 10:26 AM

Note beta cluster can not update T218860

mwscript mergeMessageFileList.php --wiki="dewiktionary" --list-file="/srv/mediawiki-staging/wmf-config/extension-list" --output="/tmp/tmp.q0bUYjIqrn" 

     ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed.

     ExtensionDependencyError from line 293 of /srv/mediawiki-staging/php-master/includes/registration/ExtensionRegistry.php:
        FundraisingTranslateWorkflow requires Translate to be installed.

On production I think we generated the mergeMessageFileList.php before the issue has been introduced and thus this train is not affected. But next time we run that script or on the next train, we might well face the exact same issue.

So I don't know. Maybe we should just add the task as a blocker to next train.