Page MenuHomePhabricator

MFA: Increase test coverage of Browser.js
Closed, ResolvedPublic

Description

per https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector#Speed_up_unit_test_execution_and_increase_code_coverage

Browser.js doesn't enjoy 100% test coverage. It was only partly increased in T203818.

! In T203818#4656437, @Jdrewniak wrote:
@Jdlrobson well I would hate to say that something is impossible.

I've been exploring the NYC coverage tool and discovered that it can produce pretty nice HTML reports (by changing the npm coverage script to nyc --reporter=html npm -s run test:unit).The output of these reports can give us more insight into what is and isn't being tested.

Here's the output as of the latest patch https://people.wikimedia.org/~jdrewniak/coverage-report/. As you can see in Browser.js, the lines that aren't run relate to: the memoized function, iOS version, and getSingleton method.

Knowing this now, I think we can increase the code-coverage of the Browser.js tests.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 9:38 PM
Jdlrobson triaged this task as Medium priority.Oct 18 2018, 8:30 PM
Jdlrobson renamed this task from Increase test coverage of Browser.js to MFA: Increase test coverage of Browser.js.Nov 15 2018, 7:06 PM
Jdlrobson raised the priority of this task from Medium to Needs Triage.Nov 26 2018, 10:34 PM