Page MenuHomePhabricator
Create Task
Maniphest T206728

AutoLoaderStructureTest works incorrectly on extensions using PSR-4 autoloading and class_alias
Open, Needs TriagePublic
Actions

Description

When fixing up https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/465562/

If we add these classes below in AutoloadClasses

		"EchoAttributeManager": "includes/AttributeManager.php",
		"EchoCallbackIterator": "includes/Iterator/CallbackIterator.php",
		"EchoDbFactory": "includes/DbFactory.php",
		"EchoDiscussionParser": "includes/DiscussionParser.php",
		"EchoEvent": "includes/Model/Event.php",
		"EchoEventMapper": "includes/Mapper/EventMapper.php",
		"EchoEventPresentationModel": "includes/Formatters/EventPresentationModel.php",
		"EchoModerationController": "includes/Controller/ModerationController.php",
		"EchoNotificationController": "includes/Controller/NotificationController.php",
		"EchoUserLocator": "includes/UserLocator.php",

We get a failure in AutoLoaderStructureTest::testAutoLoadConfig over at https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-hhvm-docker/7577/console

01:42:24 1) AutoLoaderStructureTest::testAutoLoadConfig
01:42:24 Failed asserting that two arrays are equal.
01:42:24 --- Expected
01:42:24 +++ Actual
01:42:24 @@ @@
01:42:24      'ZeroPortal\ZeroConfigView' => '/workspace/src/extensions/Zer...ew.php'
01:42:24 +    'MediaWiki\Notifications\AttributeManager' => '/workspace/src/extensions/Ech...er.php'
01:42:24 +    'MediaWiki\Notifications\Iterator\CallbackIterator' => '/workspace/src/extensions/Ech...or.php'
01:42:24 +    'MediaWiki\Notifications\DbFactory' => '/workspace/src/extensions/Ech...ry.php'
01:42:24 +    'MediaWiki\Notifications\DiscussionParser' => '/workspace/src/extensions/Ech...er.php'
01:42:24 +    'MediaWiki\Notifications\Model\Event' => '/workspace/src/extensions/Ech...nt.php'
01:42:24 +    'MediaWiki\Notifications\Mapper\EventMapper' => '/workspace/src/extensions/Ech...er.php'
01:42:24 +    'MediaWiki\Notifications\Formatters\EventPresentationModel' => '/workspace/src/extensions/Ech...el.php'
01:42:24 +    'MediaWiki\Notifications\Controller\ModerationController' => '/workspace/src/extensions/Ech...er.php'
01:42:24 +    'MediaWiki\Notifications\Controller\NotificationController' => '/workspace/src/extensions/Ech...er.php'
01:42:24 +    'MediaWiki\Notifications\UserLocator' => '/workspace/src/extensions/Ech...or.php'
01:42:24  )
01:42:24 
01:42:24 /workspace/src/tests/phpunit/structure/AutoLoaderStructureTest.php:19
01:42:24 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
01:42:24 /workspace/src/maintenance/doMaintenance.php:94

If we remove those.... https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-hhvm-docker/7578/console

01:48:40 Fatal error: unknown class EchoEventPresentationModel in /workspace/src/extensions/Flow/includes/Notifications/FlowPresentationModel.php on line 9

It seems to be an issue related to AutoLoaderStructureTest, as the class_alias classes should be in AutoloadClasses for the correct behaviour

Details

SubjectRepoBranchLines +/-
Remove array_unique() on expected classes in checkAutoLoadConf()mediawiki/coremaster+9 -8
Customize query in gerrit

Event Timeline

Reedy created this task.Oct 11 2018, 1:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2018, 1:00 AM
Reedy added a subscriber: xSavitar.Oct 11 2018, 1:00 AM
Reedy renamed this task from PSR-4 autoload doesn't seem to work with class_alias to AutoLoaderStructureTest works incorrectly on extensions using PSR-4 autoloading and class_alias.Oct 11 2018, 1:42 AM
Reedy added a project: MediaWiki-Core-Tests.
Reedy updated the task description. (Show Details)
xSavitar awarded a token.Oct 11 2018, 11:21 AM
xSavitar added a project: User-xSavitar.Nov 7 2018, 4:47 PM
gerritbot subscribed.Nov 7 2018, 5:18 PM

Change 472202 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/core@master] Remove array_unique() on expected classes in checkAutoLoadConf()

https://gerrit.wikimedia.org/r/472202

gerritbot added a project: Patch-For-Review.Nov 7 2018, 5:18 PM
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.Nov 7 2018, 5:42 PM
gerritbot added a comment.Dec 4 2018, 7:06 AM

Change 472202 merged by jenkins-bot:
[mediawiki/core@master] Remove array_unique() on expected classes in checkAutoLoadConf()

https://gerrit.wikimedia.org/r/472202

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 4 2018, 8:00 AM
xSavitar removed a project: Patch-For-Review.Dec 4 2018, 10:17 AM
xSavitar moved this task from Doing [WIP] to Backlog on the User-xSavitar board.
xSavitar added subscribers: thiemowmde, Legoktm.EditedDec 4 2018, 10:24 AM

Some good progress so far by @Reedy (thanks), @thiemowmde (for reviewing thoroughly) and finally @Legoktm (for landing the patch). So now with this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/466675 with 1 autoloaded class via class aliases and psr-4, we have the following error;

10:47:05 1) AutoLoaderStructureTest::testAutoLoadConfig
10:47:05 Failed asserting that two arrays are equal.
10:47:05 --- Expected
10:47:05 +++ Actual
10:47:05 @@ @@
10:47:05      'ZeroPortal\ZeroConfigView' => '/workspace/src/extensions/Zer...ew.php'
10:47:05 +    'MediaWiki\GuidedTour\Launcher' => '/workspace/src/extensions/Gui...er.php'
10:47:05  )
10:47:05 
10:47:05 /workspace/src/tests/phpunit/structure/AutoLoaderStructureTest.php:19
10:47:05 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
10:47:05 /workspace/src/maintenance/doMaintenance.php:94
10:47:05

So still for some reason, when autoload classes via class aliases and psr-4 are used at the same time, the mapping of classes to their corresponding files is not still composed correctly. A follow up patch to AutoloaderStructureTest coming soon...

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Dec 8 2018, 11:37 PM
xSavitar removed a project: User-xSavitar.Dec 18 2018, 8:19 PM
pmiazga subscribed.Apr 8 2019, 11:22 PM

I encountered the same issue while working on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/502278. After renaming MenuBuilder to Group and registering it via PSR-4 the AutoLoaderStructureTest started to fail. After adding MediaWiki\Minerva\Menu\Group also to AutoloadClasses it works again.

xSavitar added a comment.Apr 8 2019, 11:34 PM

@pmiazga, thanks, will try this!

Tacsipacsi subscribed.Apr 24 2022, 11:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL