Page MenuHomePhabricator

VE's image type dropdown icon of media dialog need to be aligned to icon guidelines
Closed, ResolvedPublic


VE currently features four icons in “Image type” dropdown that are outdate and need to be aligned to new media icons look/icon guidelines.

image.png (1×1 px, 86 KB)

Event Timeline

Esanders added a subscriber: Esanders.

It's a bit against convention to even have icons in a dropdown (as in Apex the selected item uses a check icon). If we really want to show the user what each mode looks like we should probably use larger images and a different widget.

hi @Volker_E - here are some proposed updated icons attached. We could potentially try showing this in a toggle select widget instead (like the Left/Right/Center position field above Image type in the screenshot) per ESanders suggestion...

Re-assigning this as you've already shared the direction.

Change 486168 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'imageLayout*' icons to 'editing-advanced' pack

These icons are very much specific to a quirk of MediaWiki syntax, do we definitely want to upstream them to OOUI?

I don't have too strong of an opinion here, but we also feature 'mathematicsDisplay*' ones now. Where do you want to/where should we draw the boundary?
The performance problem won't disappear completely, it will get better though with T160690 and T198770 in mid-term.
On these specific icons, they also go into editing-advanced. Not sure if there's a lot of extensions outside VE that might use that pack at all even with 'language' in, if this is what makes you hesitate…

Change 486168 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'imageLayout*' icons to 'editing-advanced' pack

Change 494883 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.4

Change 494883 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.4