Page MenuHomePhabricator
Create Task
Maniphest T206765

config-mysql-old not being substituted by update.php
Closed, ResolvedPublic
Actions

Description

⧼config-mysql-old⧽ is being output verbatim when running update.php if your MySQL version is too old (I set $minimumVersion to 50.5.8 for testing)

$ php maintenance/update.php 
MediaWiki 1.32.0-alpha Updater

Your composer.lock file is up to date with current dependencies!
⧼config-mysql-old⧽

This is rather unhelpful, as it doesn't tell you any useful information about what version you're running, nor what version you need!

Looks to have been broken since it's introduction by @Legoktm in https://github.com/wikimedia/mediawiki/commit/574ae4929e30700e29fef0e0d4f4824599205174 for T162044

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+34 -2update.php: Ensure that error messages are properly localized
mediawiki/coreREL1_31+5 -1Load installer i18n when running update.php
mediawiki/coremaster+4 -1Load installer i18n when running update.php
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 11 2018, 2:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2018, 2:31 PM
Reedy updated the task description. (Show Details)Oct 11 2018, 2:33 PM
Reedy updated the task description. (Show Details)
Reedy added a subscriber: Legoktm.
xSavitar added a subscriber: xSavitar.Oct 11 2018, 2:38 PM
Legoktm added a comment.Oct 11 2018, 4:26 PM

...wonderful.

Reedy added a comment.Oct 11 2018, 6:13 PM

I guess it's because the installer i18n isn't being loaded by update.php (but the installer will load it), so hence it ends up with just the message key being output

gerritbot added a subscriber: gerritbot.Oct 11 2018, 6:20 PM

Change 466713 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466713

gerritbot added a project: Patch-For-Review.Oct 11 2018, 6:20 PM
gerritbot added a comment.Oct 11 2018, 6:34 PM

Change 466715 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466715

gerritbot added a comment.Oct 11 2018, 6:59 PM

Change 466713 merged by jenkins-bot:
[mediawiki/core@master] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466713

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 11 2018, 7:01 PM
gerritbot added a comment.Oct 11 2018, 9:18 PM

Change 466715 merged by jenkins-bot:
[mediawiki/core@REL1_31] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466715

ReleaseTaggerBot added a project: MW-1.31-release-notes.Oct 11 2018, 10:00 PM
Reedy closed this task as Resolved.Oct 13 2018, 12:18 AM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
cscott mentioned this in T310378: Messages don't get localized in the updater.Fri, Jun 10, 4:32 PM
cscott added a subscriber: cscott.

Regression in 1.39: T310378: Messages don't get localized in the updater.

gerritbot added a comment.Fri, Jun 10, 4:37 PM

Change 804617 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] update.php: Ensure that error messages are properly localized

https://gerrit.wikimedia.org/r/804617

gerritbot added a project: Patch-For-Review.Fri, Jun 10, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL