Page MenuHomePhabricator

config-mysql-old not being substituted by update.php
Closed, ResolvedPublic

Description

⧼config-mysql-old⧽ is being output verbatim when running update.php if your MySQL version is too old (I set $minimumVersion to 50.5.8 for testing)

$ php maintenance/update.php 
MediaWiki 1.32.0-alpha Updater

Your composer.lock file is up to date with current dependencies!
⧼config-mysql-old⧽

This is rather unhelpful, as it doesn't tell you any useful information about what version you're running, nor what version you need!

Looks to have been broken since it's introduction by @Legoktm in https://github.com/wikimedia/mediawiki/commit/574ae4929e30700e29fef0e0d4f4824599205174 for T162044

Event Timeline

Reedy created this task.Oct 11 2018, 2:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2018, 2:31 PM
Reedy updated the task description. (Show Details)Oct 11 2018, 2:33 PM
Reedy updated the task description. (Show Details)
Reedy added a subscriber: Legoktm.

...wonderful.

Reedy added a comment.Oct 11 2018, 6:13 PM

I guess it's because the installer i18n isn't being loaded by update.php (but the installer will load it), so hence it ends up with just the message key being output

Change 466713 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466713

Change 466715 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466715

Change 466713 merged by jenkins-bot:
[mediawiki/core@master] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466713

Change 466715 merged by jenkins-bot:
[mediawiki/core@REL1_31] Load installer i18n when running update.php

https://gerrit.wikimedia.org/r/466715

Reedy closed this task as Resolved.Oct 13 2018, 12:18 AM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.