Page MenuHomePhabricator

Lockdown.php is missing
Closed, ResolvedPublic

Description

Hi,

Lockdown.php is missing, is this on purpose? Version 1.30 had this file (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Lockdown/+/REL1_30), but 1.31 lacks it (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Lockdown/+/REL1_31)

The README in 1.31 still mentions "require_once( "$IP/extensions/Lockdown/Lockdown.php" );" as the way to install this extension, so I assume the file should still exist.

Thanks, have a nice day,
Cyber1000

Event Timeline

@Cyber1000 It looks like the file was renamed at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Lockdown/+/8b582f6f62f7c9d1055446ae386960d3196a6ba8

You can try:

wfLoadExtension ( 'Lockdown' );

on LocalSettings.php instead, as the extension is now migrated to use extension registration. See also the main page for Lockdown at mediawiki.org

Regards.

Hmm, reviewing that the READMEs are right and updating these little bits would do a nice GCI task.

I think that maybe leaving for some time an empty PHP entry point as explained at would be a good idea so people can notice. Do you think we need one?

I have updated the README file on master at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Lockdown/+/466788/ - I'll cherry-pick to REL1_31 as soon as it's merged.

Nemo_bis triaged this task as Medium priority.

Documentation update is cherry-picked to REL1_31 as well.

I think that maybe leaving for some time an empty PHP entry point as explained at would be a good idea so people can notice. Do you think we need one?

This remains unanswered :-)

Change 467467 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/Lockdown@master] Add PHP entry point with deprecation warning

https://gerrit.wikimedia.org/r/467467

Sorry for my late reply, I didn't know about the "extension registration", I just wanted to use the plugin in my docker-container without too much reading :-), other plugins I'm using are still using the old method.
Thanks for the change in the README, from a users perspective that's the right place and the only thing needed (no empty PHP entry point or soemthing like this)
Works perfect with wfLoadExtension ( 'Lockdown' );

Thanks again for the fast response,
Cyber1000

Change 467467 merged by jenkins-bot:
[mediawiki/extensions/Lockdown@master] Add PHP entry point with deprecation warning

https://gerrit.wikimedia.org/r/467467

Change 477046 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/Lockdown@REL1_31] Add PHP entry point with deprecation warning

https://gerrit.wikimedia.org/r/477046

Change 477046 merged by jenkins-bot:
[mediawiki/extensions/Lockdown@REL1_31] Add PHP entry point with deprecation warning

https://gerrit.wikimedia.org/r/477046

PHP entry point with warning added to master and to REL1_31. Not sure if to pick to REL1_32. Hopefully people will now notice that they should be migrating to extension registration. Closing for now. Please reopen if you find any issues. Regards.