Page MenuHomePhabricator

Remove usage of deprecated UnknownAction hook (removed in MediaWiki 1.32)
Open, LowPublic

Description

The UnknownAction hook has now been entirely removed as of MediaWiki 1.32.0 - see T178844#4659605.

./WikiArticleFeeds/WikiArticleFeeds.php:$wgHooks['UnknownAction'][] = 'WikiArticleFeeds::onUnknownAction';
./WikiArticleFeeds/WikiArticleFeeds_body.php:	public static function onUnknownAction( $action, $article ) {

Extensions using the hook hosted on gerrit:

  • AccessControl
  • Favorites
  • Push
  • WikiArticleFeeds
  • BlueSpiceBlog

Event Timeline

@D3r1ck01: Requires a potential mentor who is knowledgeable enough to judge whether the docs are good enough to allow a student to update that code. Note that there is no 1:1 replacement function call.

Please, please, please can you make sure that T178844 is resolved before 1.32.0 is released.

Really, we also need some time to update code to the new hook, which is dependent on having instructions on how to do it!

Change 542639 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AccessControl@master] Remove deprecated hook UnknownAction

https://gerrit.wikimedia.org/r/542639

Change 542639 merged by jenkins-bot:
[mediawiki/extensions/AccessControl@master] Remove deprecated hook UnknownAction

https://gerrit.wikimedia.org/r/542639

[BlueSpiceBlog] is currently in the proccess of getting archived: T231853

@DannyS712 Do you have plan to work this and in other extensions?

In T206832#5616012, @Zoranzoki21 wrote:

@DannyS712 Do you have plan to work this and in other extensions?

yes, I will

In T206832#5616012, @Zoranzoki21 wrote:

@DannyS712 Do you have plan to work this and in other extensions?

yes, I will

I asked because I wanted to do this, but ok, if you still want to work on this, I will leave this to you.

Change 546983 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Favorites@master] New version 1.1.3

https://gerrit.wikimedia.org/r/546983

Change 546983 merged by jenkins-bot:
[mediawiki/extensions/Favorites@master] New version 1.1.3

https://gerrit.wikimedia.org/r/546983

Change 563740 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Push@master] Remove use of UnknownAction hook, removed from mediawiki

https://gerrit.wikimedia.org/r/563740

Change 563741 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikiArticleFeeds@master] Remove use of UnknownAction hook, removed from mediawiki

https://gerrit.wikimedia.org/r/563741

Change 563740 abandoned by DannyS712:
[mediawiki/extensions/Push@master] Remove use of UnknownAction hook, removed from mediawiki

Reason:

https://gerrit.wikimedia.org/r/563740

Change 563741 abandoned by DannyS712:
[mediawiki/extensions/WikiArticleFeeds@master] Remove use of UnknownAction hook, removed from mediawiki

Reason:

https://gerrit.wikimedia.org/r/563741

DannyS712 removed a project: User-DannyS712.