Page MenuHomePhabricator
Create Task
Maniphest T206832

Remove usage of deprecated UnknownAction hook (removed in MediaWiki 1.32)
Open, LowPublic
Actions

Description

The UnknownAction hook has now been entirely removed as of MediaWiki 1.32.0 - see T178844#4659605.

./WikiArticleFeeds/WikiArticleFeeds.php:$wgHooks['UnknownAction'][] = 'WikiArticleFeeds::onUnknownAction';
./WikiArticleFeeds/WikiArticleFeeds_body.php:	public static function onUnknownAction( $action, $article ) {

Extensions using the hook hosted on gerrit:

  • AccessControl
  • Favorites
  • Push
  • WikiArticleFeeds
  • BlueSpiceBlog

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiArticleFeedsmaster+0 -88Remove use of UnknownAction hook, removed from mediawiki
mediawiki/extensions/Pushmaster+0 -18Remove use of UnknownAction hook, removed from mediawiki
mediawiki/extensions/Favoritesmaster+112 -161New version 1.1.3
mediawiki/extensions/AccessControlmaster+1 -15Remove deprecated hook UnknownAction
Customize query in gerrit

Related Objects

Event Timeline

Aklapper created this task.Oct 12 2018, 4:10 AM
xSavitar added a subscriber: xSavitar.Oct 12 2018, 10:22 AM

Could this go in for Google-Code-in-2018?

Aklapper added a comment.Oct 12 2018, 4:41 PM

@D3r1ck01: Requires a potential mentor who is knowledgeable enough to judge whether the docs are good enough to allow a student to update that code. Note that there is no 1:1 replacement function call.

HappyDog added a subscriber: HappyDog.Oct 12 2018, 8:52 PM

Please, please, please can you make sure that T178844 is resolved before 1.32.0 is released.

Really, we also need some time to update code to the new hook, which is dependent on having instructions on how to do it!

DannyS712 claimed this task.Sep 25 2019, 8:28 PM
DannyS712 triaged this task as Low priority.
DannyS712 added a subscriber: DannyS712.

T178844: Provide documentation for migrating away from UnknownAction hook. was resolved, 1.32.0 was cut, and there are still a number of calls to the hook. See https://codesearch.wmflabs.org/search/?q=UnknownAction&i=nope&files=&repos=

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 25 2019, 8:28 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Sep 25 2019, 8:28 PM
DannyS712 updated the task description. (Show Details)Oct 11 2019, 5:13 AM
DannyS712 added a project: Technical-Debt (Deprecation process).Oct 12 2019, 2:00 AM
gerritbot added a comment.Oct 12 2019, 2:00 AM

Change 542639 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AccessControl@master] Remove deprecated hook UnknownAction

https://gerrit.wikimedia.org/r/542639

gerritbot added a project: Patch-For-Review.Oct 12 2019, 2:00 AM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Oct 12 2019, 10:50 PM
Aklapper added projects: MediaWiki-extensions-AccessControl, BlueSpice, MediaWiki-extensions-General, Google-Code-in-2019.Oct 13 2019, 9:05 AM
Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2019 board.
gerritbot added a comment.Oct 16 2019, 3:59 PM

Change 542639 merged by jenkins-bot:
[mediawiki/extensions/AccessControl@master] Remove deprecated hook UnknownAction

https://gerrit.wikimedia.org/r/542639

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 4:10 PM
DannyS712 updated the task description. (Show Details)Oct 16 2019, 4:42 PM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Oct 16 2019, 4:45 PM
Pwirth added a subscriber: Pwirth.Oct 17 2019, 7:37 AM

[BlueSpiceBlog] is currently in the proccess of getting archived: T231853

Pwirth updated the task description. (Show Details)Oct 29 2019, 8:04 AM
HappyDog removed a subscriber: HappyDog.Oct 29 2019, 9:19 AM
Kizule added a subscriber: Kizule.Oct 29 2019, 4:32 PM

@DannyS712 Do you have plan to work this and in other extensions?

DannyS712 added a comment.Oct 29 2019, 4:38 PM
In T206832#5616012, @Zoranzoki21 wrote:

@DannyS712 Do you have plan to work this and in other extensions?

yes, I will

Kizule added a comment.EditedOct 29 2019, 4:39 PM
In T206832#5616076, @DannyS712 wrote:
In T206832#5616012, @Zoranzoki21 wrote:

@DannyS712 Do you have plan to work this and in other extensions?

yes, I will

I asked because I wanted to do this, but ok, if you still want to work on this, I will leave this to you.

gerritbot added a comment.Oct 29 2019, 5:03 PM

Change 546983 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Favorites@master] New version 1.1.3

https://gerrit.wikimedia.org/r/546983

gerritbot added a project: Patch-For-Review.Oct 29 2019, 5:03 PM
gerritbot added a comment.Nov 4 2019, 10:06 PM

Change 546983 merged by jenkins-bot:
[mediawiki/extensions/Favorites@master] New version 1.1.3

https://gerrit.wikimedia.org/r/546983

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 10:12 PM
DannyS712 updated the task description. (Show Details)Nov 4 2019, 10:53 PM
Kizule removed a project: Google-Code-in-2019.Nov 5 2019, 11:59 AM

Removed from GCI as @DannyS712 works on this.

DannyS712 moved this task from Unsorted to Needs removal on the Technical-Debt board.Nov 18 2019, 7:42 AM
gerritbot added a comment.Jan 12 2020, 9:56 PM

Change 563740 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Push@master] Remove use of UnknownAction hook, removed from mediawiki

https://gerrit.wikimedia.org/r/563740

gerritbot added a project: Patch-For-Review.Jan 12 2020, 9:56 PM

Change 563741 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikiArticleFeeds@master] Remove use of UnknownAction hook, removed from mediawiki

https://gerrit.wikimedia.org/r/563741

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jan 12 2020, 9:58 PM
gerritbot added a comment.Aug 29 2020, 12:48 AM

Change 563740 abandoned by DannyS712:
[mediawiki/extensions/Push@master] Remove use of UnknownAction hook, removed from mediawiki

Reason:

https://gerrit.wikimedia.org/r/563740

gerritbot added a comment.Aug 29 2020, 12:48 AM

Change 563741 abandoned by DannyS712:
[mediawiki/extensions/WikiArticleFeeds@master] Remove use of UnknownAction hook, removed from mediawiki

Reason:

https://gerrit.wikimedia.org/r/563741

DannyS712 removed DannyS712 as the assignee of this task.Aug 29 2020, 12:48 AM
DannyS712 removed a project: User-DannyS712.
Pwirth removed a project: BlueSpice.Oct 15 2020, 8:54 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL