Page MenuHomePhabricator

Wrong localisation message used by VE for the Edit tab in single-edit-tab mode
Closed, ResolvedPublic

Description

(split off from T206554 by @alexhollender)

On English Wikipedia, when using the Vector skin, with the "Editing mode" preference set to "Remember my last editor", and the remembered last editor being the visual editor, clicking the "Edit" tab link will change its label to "Edit this page".

This is because we incorrectly use the 'edit' message, rather than 'vector-view-edit', and on English Wikipedia it is customized (compare https://en.wikipedia.org/wiki/MediaWiki:Edit vs https://en.wikipedia.org/wiki/MediaWiki:Edit/en). The customization dates to the days of yore, it was probably intended for MonoBook (where changing the text to make the link slightly larger is a reasonable decision).

before clicking "Edit"after clicking "Edit"
normal
Screen Shot 2018-10-12 at 5.19.28 PM.png (236×2 px, 124 KB)
Screen Shot 2018-10-12 at 5.19.39 PM.png (298×2 px, 158 KB)
?uselang=qqx
Screen Shot 2018-10-12 at 5.18.54 PM.png (242×2 px, 152 KB)
Screen Shot 2018-10-12 at 5.19.07 PM.png (366×2 px, 213 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Additional related issue I found when debugging this issue: on file description pages for files from Wikimedia Commons (e.g. https://en.wikipedia.org/wiki/File:A5_Aarebruecke.jpg), the edit tab normally says "Add local description", and clicking it changes it to "Edit this page". It should remain unchanged.

Change 467008 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Define localisation messages for File namespace edit tab in visual mode

https://gerrit.wikimedia.org/r/467008

Change 467009 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Use the right localisation message for edit tab on Vector skin

https://gerrit.wikimedia.org/r/467009

Change 467008 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Define localisation messages for File namespace edit tab in visual mode

https://gerrit.wikimedia.org/r/467008

Change 467009 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use the right localisation message for edit tab on Vector skin

https://gerrit.wikimedia.org/r/467009