Maniphest T206945

Suppressing or unsuppressing an AbuseLog entry with that same suppression status creates a log entry and appears successful
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Amorymeltzer
	Oct 14 2018, 2:26 PM

Description

If an oversighter goes into the suppression page (Special:AbuseLog&hide=XXXXXXXX) for an AbuseLog entry that is not suppressed, and submits the form without checking the "Suppress this entry from public view option," it nevertheless generates an "unhid" entry in the suppression log. Nothing as far as I can tell is changed.

Likewise, suppressing an already suppressed entry creates yet another "hid" entry, similarly changing nothing.

Presumably this needs an error message like other revision deletion, thus is connected to/dependent on T206938.

Details

	Subject	Repo	Branch	Lines +/-
	Overhaul the interface for hiding AbuseLog entries	mediawiki/extensions/AbuseFilter	master	+172 -68

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Daimona	T260904 Overhaul the interface for suppressing AbuseLog entries
		Resolved	BUG REPORT	Daimona	T206945 Suppressing or unsuppressing an AbuseLog entry with that same suppression status creates a log entry and appears successful

Event Timeline

Amorymeltzer created this task.Oct 14 2018, 2:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2018, 2:26 PM

Haven't tested, but if it's true this is strongly related to T115530, which would give a sense to that checkbox.

Change 467774 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Overhaul the interface for hiding AbuseLog entries

https://gerrit.wikimedia.org/r/467774

gerritbot added a project: Patch-For-Review.Oct 16 2018, 8:00 PM

Daimona claimed this task.Oct 16 2018, 8:00 PM

Amorymeltzer renamed this task from Unsuppressing an unsuppressed AbuseLog entry creates a log entry and appears successful? to Suppressing or unsuppressing an AbuseLog entry with that same suppression status creates a log entry and appears successful.Oct 18 2018, 4:00 PM

Amorymeltzer updated the task description. (Show Details)

Amorymeltzer mentioned this in T206938: No acknowledgement when suppressing AbuseFilter entries.Nov 30 2018, 3:56 PM

Change 467774 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Overhaul the interface for hiding AbuseLog entries

https://gerrit.wikimedia.org/r/467774

DannyS712 moved this task from Backlog to Logging on the AbuseFilter board.Dec 1 2019, 8:57 AM

JJMC89 merged a task: T252360: A suppression log entry is created for unhiding abuse filter log entries that were not previously hidden.May 11 2020, 4:13 AM

JJMC89 changed the subtype of this task from "Task" to "Bug Report".

JJMC89 subscribed.

Daimona added a parent task: T260904: Overhaul the interface for suppressing AbuseLog entries.Aug 20 2020, 12:12 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 15 2020, 1:04 PM

Daimona edited projects, added Patch-For-Review; removed Patch-Needs-Improvement.Nov 25 2020, 12:50 AM

Change 467774 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Overhaul the interface for hiding AbuseLog entries

https://gerrit.wikimedia.org/r/467774

Daimona closed this task as Resolved.Dec 15 2020, 12:42 PM

Daimona removed a project: Patch-For-Review.