Page MenuHomePhabricator

Optimize settings for extension.json
Open, MediumPublic


Both settings don't have the best style:

  • To modify a class mamber variable isn't the normal way to define settings. Furthermore, it's incompatible with extension.json, as classes aren't autoloaded in LocalSettings.php yet.
  • As config settings are merged, you have to specify disabled functions instead of enabled functions explicitly to get useful semantics.

Event Timeline

MGChecker renamed this task from Use globals for max Loop count to Use settings compatible with extension.json.Oct 14 2018, 9:45 PM
MGChecker renamed this task from Use settings compatible with extension.json to Optimize settings for extension.json.Oct 14 2018, 11:10 PM

Change 468342 had a related patch set uploaded (by MGChecker; owner: MGChecker):
[mediawiki/extensions/Loops@master] Replace $maxLoops class member with global

Change 468342 merged by jenkins-bot:
[mediawiki/extensions/Loops@master] Replace $maxLoops class member with global

MGChecker triaged this task as Medium priority.Oct 30 2018, 8:50 PM