Page MenuHomePhabricator
Create Task
Maniphest T206967

Job cirrusSearchLinksUpdatePrioritized failures "Call to getNamespace() on a non-object"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: 3584b53c765c52d29a99f42d

message
BadMethodCallException: Call to a member function getNamespace() on a non-object (null)

[{exception_id}] {exception_url} from line 520 of /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Updater.php
trace
#0 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Updater.php(360): CirrusSearch\Updater::extractDisplayTitle(Title, ParserOutput)
#1 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Updater.php(407): CirrusSearch\Updater::buildDocument(CirrusSearch, WikiPage, CirrusSearch\Connection, integer, integer, integer)
#2 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Updater.php(205): CirrusSearch\Updater->buildDocumentsForPages(array, integer)
#3 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Updater.php(84): CirrusSearch\Updater->updatePages(array, integer)
#4 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Job/LinksUpdate.php(52): CirrusSearch\Updater->updateFromTitle(Title)
#5 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CirrusSearch/includes/Job/Job.php(99): CirrusSearch\Job\LinksUpdate->doJob()
#6 /srv/mediawiki/php-1.32.0-wmf.24/extensions/EventBus/includes/JobExecutor.php(65): CirrusSearch\Job\Job->run()
#7 /srv/mediawiki/rpc/RunSingleJob.php(67): JobExecutor->execute(array)

Impact

Unknown.

Notes

Captured 152 times in Logstash in the last 30 days. Seems to happen in bursts, possibly due to it (consistently) happening after certain page actions are performed.

The burst made it appear like a regression from a specific deployment, when actually it had been dormant for a few days and just happened to pop up.

Details

SubjectRepoBranchLines +/-
Don't try to detect the namespace prefixmediawiki/extensions/CirrusSearchwmf/1.33.0-wmf.1+10 -0
Don't try to detect the namespace prefixmediawiki/extensions/CirrusSearchmaster+10 -0
Customize query in gerrit

Event Timeline

Krinkle created this task.Oct 15 2018, 12:43 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 15 2018, 12:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Oct 24 2018, 5:24 PM
Krinkle moved this task from Older to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Oct 24 2018, 5:35 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.
dcausse claimed this task.Oct 25 2018, 8:25 AM
dcausse triaged this task as Medium priority.
dcausse moved this task from needs triage to Up Next on the Discovery-Search board.
dcausse subscribed.

This code is relatively new it's probable that it's not aware of all the scenario, I will take a look.

dcausse moved this task from Up Next to Current work on the Discovery-Search board.Oct 25 2018, 8:25 AM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 25 2018, 1:28 PM
gerritbot subscribed.Oct 25 2018, 1:28 PM

Change 469615 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Don't try to detect the namespace prefix

https://gerrit.wikimedia.org/r/469615

gerritbot added a project: Patch-For-Review.Oct 25 2018, 1:28 PM
gerritbot added a comment.Oct 26 2018, 3:25 PM

Change 469615 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't try to detect the namespace prefix

https://gerrit.wikimedia.org/r/469615

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 26 2018, 4:00 PM
gerritbot added a comment.Oct 27 2018, 11:17 PM

Change 470223 had a related patch set uploaded (by Krinkle; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.33.0-wmf.1] Don't try to detect the namespace prefix

https://gerrit.wikimedia.org/r/470223

gerritbot added a comment.Oct 27 2018, 11:54 PM

Change 470223 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.33.0-wmf.1] Don't try to detect the namespace prefix

https://gerrit.wikimedia.org/r/470223

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.1; 2018-10-23); removed MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 28 2018, 12:00 AM
Stashbot subscribed.Oct 28 2018, 12:03 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-28T00:03:11Z] <krinkle@deploy1001> Synchronized php-1.33.0-wmf.1/extensions/CirrusSearch: T206967 - Ia23d19cf1e6 (duration: 01m 02s)

Krinkle closed this task as Resolved.Oct 28 2018, 12:03 AM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 6 2019, 3:56 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL