Page MenuHomePhabricator

Wikistats Bug: "Anonymous Editor" is a broken link
Closed, ResolvedPublic5 Estimated Story Points

Description

On https://stats.wikimedia.org/v2/#/meta.wikimedia.org/contributing/top-editors/normal|table|1-Month|editor_type~anonymous, when searching for top editors filtered by editor type: anonymous, all entries link to "User:Anonymous Editor", which is a broken link.

Event Timeline

Nothing no works there. I think to stats.wikimedia.org should be redirected to xtools.wmflabs.org

stats.wikimedia.org is (or will be) superseded by https://stats.wikimedia.org/v2/

stats.wikimedia.org is (or will be) superseded by https://stats.wikimedia.org/v2/

This is what I told Zoranzoki21 on IRC, and clarified that XTools does not provide the same information. I believe Yair_rand is talking about Wikistats 2. The specific view in question is at https://stats.wikimedia.org/v2/#/meta.wikimedia.org/contributing/top-editors/normal|table|1-Month|editor_type~anonymous

Yes, sorry, I meant Wikistats 2, at the linked address. Thank you.

Let's change the endpoint so that instead of "Anonymous User" we return null, and we format those without link in the UI.

fdans moved this task from Incoming to Wikistats Beta on the Analytics board.

To fix bug:

  • need to change and deploy aqs glue code that is substituting IPs by anonymous editors
  • need to update wikistats UI to just print a string (but no link) if the editor_id that comes from the backend is null

Change 468927 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/aqs@master] Replace literal "anonymous editor" with null

https://gerrit.wikimedia.org/r/468927

Change 468964 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Handle null name values in top metrics from UI

https://gerrit.wikimedia.org/r/468964

Change 468927 merged by Fdans:
[analytics/aqs@master] Replace literal "anonymous editor" with null

https://gerrit.wikimedia.org/r/468927

Change 468964 merged by Mforns:
[analytics/wikistats2@master] Handle null name values in top metrics from UI

https://gerrit.wikimedia.org/r/468964

Nuria set the point value for this task to 5.Nov 1 2018, 6:45 PM