Page MenuHomePhabricator
Create Task
Maniphest T206975

vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3
Closed, ResolvedPublic
Actions

Description

km@km-pt:/srv/mediawiki/core$ php -l vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php 
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 70
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 78
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 83
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 89
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 99
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 102
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 122
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 127
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 148
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php on line 155
No syntax errors detected in vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php

Details

SubjectRepoBranchLines +/-
Use our fork of less.phpmediawiki/coreREL1_31+2 -1
Switch to our less.php forkmediawiki/vendorREL1_31+297 -292
Use our fork of less.phpmediawiki/coreREL1_32+2 -1
Use our own fork of less.phpmediawiki/vendorREL1_32+297 -292
Use our fork of less.phpmediawiki/coremaster+2 -1
Use our own fork of less.phpmediawiki/vendormaster+296 -291
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 15 2018, 6:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 6:31 AM
Legoktm moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.Oct 15 2018, 7:02 AM
MaxSem claimed this task.Oct 15 2018, 8:01 AM
Krinkle subscribed.Oct 15 2018, 10:32 PM

See https://github.com/oyejorge/less.php/pull/367.

MaxSem added a comment.Oct 15 2018, 10:45 PM

There are way more problems with this package, we've forked it.

Paladox subscribed.Oct 15 2018, 10:47 PM
MaxSem added a comment.Oct 15 2018, 11:09 PM

https://github.com/wikimedia/less.php/pull/5

Legoktm added a parent task: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Oct 16 2018, 12:25 AM
MaxSem added a subtask: T207127: Publish wikimedia/less.php on Packagist.Oct 16 2018, 5:59 AM
gerritbot subscribed.Oct 16 2018, 7:01 AM

Change 467580 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Use our fork of less.php

https://gerrit.wikimedia.org/r/467580

gerritbot added a project: Patch-For-Review.Oct 16 2018, 7:01 AM
gerritbot added a comment.Dec 1 2018, 1:16 AM

Change 477006 had a related patch set uploaded (by MaxSem; owner: Vagrant Default User):
[mediawiki/vendor@master] Use our own fork of less.php

https://gerrit.wikimedia.org/r/477006

Legoktm added projects: MW-1.31-release, MW-1.32-release.Dec 2 2018, 12:31 AM
gerritbot added a comment.Dec 2 2018, 1:40 AM

Change 477006 merged by jenkins-bot:
[mediawiki/vendor@master] Use our own fork of less.php

https://gerrit.wikimedia.org/r/477006

gerritbot added a comment.Dec 2 2018, 1:50 AM

Change 467580 merged by jenkins-bot:
[mediawiki/core@master] Use our fork of less.php

https://gerrit.wikimedia.org/r/467580

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 2 2018, 2:00 AM
gerritbot added a comment.Dec 3 2018, 6:44 PM

Change 477320 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@REL1_32] Use our fork of less.php

https://gerrit.wikimedia.org/r/477320

gerritbot added a comment.Dec 3 2018, 6:46 PM

Change 477321 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/vendor@REL1_32] Use our own fork of less.php

https://gerrit.wikimedia.org/r/477321

gerritbot added a comment.Dec 4 2018, 4:05 AM

Change 477321 merged by jenkins-bot:
[mediawiki/vendor@REL1_32] Use our own fork of less.php

https://gerrit.wikimedia.org/r/477321

gerritbot added a comment.Dec 4 2018, 4:20 AM

Change 477320 merged by jenkins-bot:
[mediawiki/core@REL1_32] Use our fork of less.php

https://gerrit.wikimedia.org/r/477320

ReleaseTaggerBot added a project: MW-1.32-notes.Dec 4 2018, 5:00 AM
RazeSoldier closed this task as Resolved.Dec 9 2018, 3:33 PM
RazeSoldier closed subtask T207127: Publish wikimedia/less.php on Packagist as Resolved.Dec 10 2018, 3:48 PM
Legoktm reopened this task as Open.Dec 18 2018, 4:09 AM

Still need to do 1.31

gerritbot added a comment.Dec 18 2018, 4:15 AM

Change 480415 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/vendor@REL1_31] Switch to our less.php fork

https://gerrit.wikimedia.org/r/480415

gerritbot added a comment.Dec 18 2018, 4:15 AM

Change 480417 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_31] Use our fork of less.php

https://gerrit.wikimedia.org/r/480417

gerritbot added a comment.Dec 18 2018, 4:30 AM

Change 480415 merged by jenkins-bot:
[mediawiki/vendor@REL1_31] Switch to our less.php fork

https://gerrit.wikimedia.org/r/480415

gerritbot added a comment.Dec 18 2018, 5:45 AM

Change 480417 merged by jenkins-bot:
[mediawiki/core@REL1_31] Use our fork of less.php

https://gerrit.wikimedia.org/r/480417

Legoktm closed this task as Resolved.Dec 18 2018, 5:48 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes.Dec 18 2018, 6:00 AM
Krinkle added a project: Less.php.Jan 17 2023, 11:34 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 17 2023, 11:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL