Page MenuHomePhabricator
Create Task
Maniphest T206976

LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3
Closed, ResolvedPublic
Actions

Description

km@km-pt:/srv/mediawiki/core$ php -l extensions/LocalisationUpdate/includes/QuickArrayReader.php
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in extensions/LocalisationUpdate/includes/QuickArrayReader.php on line 36
No syntax errors detected in extensions/LocalisationUpdate/includes/QuickArrayReader.php

Details

SubjectRepoBranchLines +/-
Use "break" instead of "continue" inside a switchmediawiki/extensions/LocalisationUpdateREL1_32+1 -1
Use "break" instead of "continue" inside a switchmediawiki/extensions/LocalisationUpdateREL1_31+1 -1
Use "break" instead of "continue" inside a switchmediawiki/extensions/LocalisationUpdatemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 15 2018, 6:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 6:40 AM
Legoktm moved this task from Backlog to Bundled extensions/skins on the PHP 7.3 support board.Oct 15 2018, 7:02 AM
Legoktm added a subscriber: RazeSoldier.Oct 15 2018, 6:03 PM
Legoktm added a parent task: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Oct 16 2018, 12:25 AM
Legoktm added projects: MW-1.32-release, MW-1.31-release.Oct 22 2018, 11:43 PM
RazeSoldier claimed this task.Nov 10 2018, 6:59 AM
RazeSoldier triaged this task as Medium priority.
gerritbot subscribed.Nov 10 2018, 7:34 AM

Change 472761 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/LocalisationUpdate@master] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/472761

gerritbot added a project: Patch-For-Review.Nov 10 2018, 7:34 AM
gerritbot added a comment.Nov 13 2018, 1:21 PM

Change 472761 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@master] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/472761

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 13 2018, 2:00 PM
gerritbot added a comment.Nov 13 2018, 2:40 PM

Change 473218 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/LocalisationUpdate@REL1_32] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/473218

gerritbot added a comment.Nov 13 2018, 2:40 PM

Change 473219 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/LocalisationUpdate@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/473219

gerritbot added a comment.Nov 15 2018, 6:00 PM

Change 473219 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@REL1_31] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/473219

gerritbot added a comment.Nov 15 2018, 6:00 PM

Change 473218 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@REL1_32] Use "break" instead of "continue" inside a switch

https://gerrit.wikimedia.org/r/473218

RazeSoldier closed this task as Resolved.Nov 15 2018, 11:56 PM
RazeSoldier removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL