Page MenuHomePhabricator
Create Task
Maniphest T20698

Use file.inc or file.php, not file.inc.php
Closed, ResolvedPublic
Actions

Description

These references and the files they refer to should be just .inc:

maintenance/updateArticleCount.php:13:require_once( 'updateArticleCount.inc.php' );
maintenance/importImages.php:14:require_once( 'importImages.inc.php' );
maintenance/reassignEdits.php:14:require_once( 'reassignEdits.inc.php' );
maintenance/deleteOrphanedRevisions.php:15:require_once( 'deleteOrphanedRevisions.inc.php' );
docs/php-memcached/Documentation:166:require("MemCachedClient.inc.php");

In fact some smaller ones could be merged with their .php counterpart.

Version: 1.16.x
Severity: enhancement

Details

Reference
bz18698

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:32 PM
• bzimport added a project: MediaWiki-Maintenance-system.
• bzimport set Reference to bz18698.
• bzimport added a subscriber: Unknown Object (MLST).
Jidanni created this task.May 6 2009, 7:26 PM
• bzimport added a comment.May 9 2009, 12:18 PM

karun.84 wrote:

Patch that corrects .inc.php references to be .inc

Hello,
I have created a patch that corrects the references in the files mentioned on the bug to be .inc rather than .inc.php

How do we go about getting the .inc.php files renamed to .inc in SVN? What criteria should we use to determine if .inc files should be included in the .php file? As the bug mentions some of them are small and could be included.

Attached:

bug18698.patch2 KBDownload

• bzimport added a comment.May 16 2009, 2:17 AM

karun.84 wrote:

Comment on attachment 6099
Patch that corrects .inc.php references to be .inc

The following files need renaming as a part of the patch
maintenance/updateArticle.inc.php to maintenance/updateArticle.inc

maintenance/importImages.inc.php to maintenance/importImages.inc

maintenance/reassignEdits.inc.php to maintenance/reassignEdits.inc

maintenance/deleteOrphanedRevisions.inc.php to maintenance/deleteOrphanedRevisions.inc

• bzimport added a comment.May 16 2009, 2:19 AM

karun.84 wrote:

As per the mailing list discussion on Wikitech-l with the subject "Procedure for renaming files as a part of patches" on the 16th of May 2009, I have updated the patch to include the files to be renamed.

tstarling added a comment.May 16 2009, 3:23 AM

I would rather see all the .php files (except the entry points) renamed to .inc. Is there some reason you think it should be the other way around?

http://marc.info/?l=wikitech-l&m=121346275503945&w=2
http://marc.info/?l=wikitech-l&m=121357278830503&w=2

tstarling added a comment.May 18 2009, 3:21 AM

Sorry, misread.

shinjiman added a comment.May 23 2009, 7:26 PM

Applied on r50942.

The patch has been applied except the "docs/php-memcached/Documentation" part.
The MemCachedClient.inc.php file has been deleted on r4945 and this file was
totally outdated in respect to the memcached-client.php file that are currently using.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits