Given that MediaWiki 1.31 is LTS, we should make it compatible with PHP 7.3 (like we did with 1.27 at some point). This is necessary for Debian, as it'll be shipping with both 1.31 and 7.3.
I started filing some tasks, it looks like some require commits to be backported, while others will require fixes in master as well.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Reedy | T206988 MediaWiki 1.31.x should be compatible with PHP 7.3 | |||
| Resolved | Legoktm | T206979 compact(): Undefined variable in LocalisationCache on PHP 7.3 | |||
| Resolved | RazeSoldier | T206976 LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3 | |||
| Resolved | MaxSem | T206975 vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3 | |||
| Resolved | MaxSem | T207127 Publish wikimedia/less.php on Packagist | |||
| Resolved | RazeSoldier | T206974 maintenance/storage/checkStorage.php triggers warnings in PHP 7.3 | |||
| Resolved | RazeSoldier | T206977 ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3 | |||
| Resolved | RazeSoldier | T200595 [PHP 7.3] Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? | |||
| Resolved | • santhosh | T207100 LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 | |||
| Resolved | MarkAHershberger | T215632 UploadStash should use a valid regex |
Yeah, I'd agree it's worth backporting fixes from master where we have them. Hopefully prevent a few bug reports down the line
@Jdforrester-WMF I removed T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()" as a blocker since so far testing shows that PHPUnit 6 seems to work fine on PHP 7.3.
I backported everything that I could find with "7.2" and "7.3" in the commit message - 7.2 tests pass now on 1.31.
MediaWiki 1.32.x should be compatible with PHP 7.3? If should, may be add MW-1.32-release.
If older versions are compatible, newer versions are too.
I'm not sure this task needs to stay open if everything is known to be working and test passing... But was that only on 7.2, not 7.3?
RazeSoldier added a subtask: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.
This is a final failed test, for me.