Page MenuHomePhabricator
Create Task
Maniphest T207024

Urbanecm's tools have no gate-and-submit-l10n defined
Closed, ResolvedPublic
Actions

Description

This causes patches from l10n-bot to be never merged automatically.

Details

SubjectRepoBranchLines +/-
Add gate-and-submit-l10n to several Urbanecm's toolsintegration/configmaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm triaged this task as High priority.Oct 15 2018, 12:45 PM
Urbanecm created this task.
gerritbot subscribed.Oct 15 2018, 12:46 PM

Change 467329 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[integration/config@master] Add gate-and-submit-l10n to several Urbanecm's tools

https://gerrit.wikimedia.org/r/467329

gerritbot added a project: Patch-For-Review.Oct 15 2018, 12:46 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Oct 15 2018, 12:46 PM
Urbanecm closed this task as a duplicate of T206991: Document the process of setting up L10n-bot integration for repositories.Oct 15 2018, 1:01 PM
Urbanecm reopened this task as Open.Oct 15 2018, 2:25 PM

Maybe not a dupe, but relevant.

gerritbot added a comment.Oct 15 2018, 2:26 PM

Change 467329 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[integration/config@master] Add gate-and-submit-l10n to several Urbanecm's tools

https://gerrit.wikimedia.org/r/467329

Nikerabbit subscribed.Oct 19 2018, 6:51 AM

What's the difference with https://gerrit.wikimedia.org/r/c/wikipedia/gadgets/ProveIt/+/468208 that gets V+2 but not submitted automatically?

Legoktm subscribed.Oct 19 2018, 6:56 AM
In T207024#4679519, @Nikerabbit wrote:

What's the difference with https://gerrit.wikimedia.org/r/c/wikipedia/gadgets/ProveIt/+/468208 that gets V+2 but not submitted automatically?

AFAICT jenkins-bot doesn't have submit permissions on that repo.

gerritbot added a comment.Oct 19 2018, 6:59 AM

Change 467329 merged by jenkins-bot:
[integration/config@master] Add gate-and-submit-l10n to several Urbanecm's tools

https://gerrit.wikimedia.org/r/467329

Legoktm mentioned this in rWGPI0e3dc48b82a5: Allow l10n-bot to submit per T207024#4679519.Oct 19 2018, 7:00 AM
hashar closed this task as Resolved.Oct 19 2018, 11:00 AM
Urbanecm mentioned this in T207492: Allow jenkins-bot to submit on wikipedia/gadgets/ProveIt.Oct 19 2018, 4:25 PM
Urbanecm added a comment.Oct 19 2018, 4:31 PM
In T207024#4679543, @Legoktm wrote:
In T207024#4679519, @Nikerabbit wrote:

What's the difference with https://gerrit.wikimedia.org/r/c/wikipedia/gadgets/ProveIt/+/468208 that gets V+2 but not submitted automatically?

AFAICT jenkins-bot doesn't have submit permissions on that repo.

You're right. Created T207492. Please do not merge or revert https://phabricator.wikimedia.org/rWGPI0e3dc48b82a5cd3fdaa1b6752534ce7dda4c363d, l10n-bot doesn't submit anymore; this was handed over to jenkins in T91707: L10n-bot should not force-merge / override Jenkins (breaks the build).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL