Page MenuHomePhabricator
Create Task
Maniphest T207059

In Wikidata Query GUI, make the placeholder update the language dynamically
Closed, ResolvedPublic
Actions

Description

This task is about the Wikidata Query GUI (General user interface).

In the Input box, the placeholder is not dynamically updating until we refreshing the page.

Steps to Reproduce:

  1. Currently Let's Assume the Language be English.
  2. Now Change the Language to Spanish or Francais, All the buttons were changed to Spanish/Francais, Except the placeholder.
  3. Now Refresh the page then you can see that the placeholder is changing its language.

Expected:
By changing the language the placeholder should change dynamically.

After Changing the language from English to Francais

Selection_003.png (250×1 px, 21 KB)

After Refreshing the page

Selection_004.png (249×1 px, 21 KB)

To clone and Install the wikidata-query-gui follow https://github.com/wikimedia/wikidata-query-gui#readme

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit. The code repository is wikidata/query/gui.

GCI Mentors: @Gopavasanth

Details

ProjectBranchLines +/-Subject
wikidata/query/gui-deployproduction+5 -5Merging from b1b825c40771891b8cb47dc6a3ca838d182efa70:
wikidata/query/guimaster+17 -29Refactor editor placeholder translation setup
wikidata/query/guimaster+14 -4Make placholder update on language change
Customize query in gerrit

Related Objects

Event Timeline

Gopavasanth created this task.Oct 15 2018, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 4:48 PM
Gopavasanth added a project: Google-Summer-of-Code (2018).Oct 15 2018, 4:54 PM
Gopavasanth updated the task description. (Show Details)
Aklapper updated the task description. (Show Details)Oct 16 2018, 8:25 PM
Aklapper removed a project: Google-Summer-of-Code (2018).
Aklapper added a project: Google-Code-in-2018.
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.
Aklapper renamed this task from Placeholder doesn't update language dynamically to In Wikidata Query GUI, make the placeholder update the language dynamically.Oct 16 2018, 8:27 PM
Aklapper updated the task description. (Show Details)

@Gopavasanth: Which programming language(s) does this task require? Can you please add that as tag(s) to the GCI task on the GCI site? Thanks!

Smalyshev added a subscriber: Smalyshev.Oct 16 2018, 9:08 PM

This probably requires Javascript and maybe some basic CSS knowledge.

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Oct 17 2018, 10:55 AM

This is a duplicate of the second bullet point in T168655: Query service UI editor placeholder is not translated, I believe.

Shreyasminocha claimed this task.Nov 4 2018, 6:50 PM
gerritbot added a subscriber: gerritbot.Nov 5 2018, 6:23 AM

Change 471668 had a related patch set uploaded (by Shreyasminocha; owner: Shreyasminocha):
[wikidata/query/gui@master] Make placeholder update language dynamically

https://gerrit.wikimedia.org/r/471668

gerritbot added a project: Patch-For-Review.Nov 5 2018, 6:23 AM
Shreyasminocha mentioned this in rWDQG093c1dd2f712: Make placeholder update language dynamically.Nov 5 2018, 6:33 AM
Shreyasminocha mentioned this in rWDQGa9a42665b232: Make placholder update on language change.Nov 7 2018, 10:12 AM
Shreyasminocha mentioned this in rWDQGa85a0a0565d1: Make placholder update on language change.Nov 7 2018, 10:16 AM
Shreyasminocha mentioned this in rWDQGec1dc2752331: Make placholder update on language change.Nov 7 2018, 10:20 AM
gerritbot added a comment.Nov 7 2018, 1:04 PM

Change 471668 merged by jenkins-bot:
[wikidata/query/gui@master] Make placholder update on language change

https://gerrit.wikimedia.org/r/471668

gerritbot added a comment.Nov 7 2018, 1:15 PM

Change 472141 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Refactor editor placeholder translation setup

https://gerrit.wikimedia.org/r/472141

Lucas_Werkmeister_WMDE mentioned this in rWDQGa0a89dbe0557: Refactor editor placeholder translation setup.Nov 7 2018, 1:17 PM
Lucas_Werkmeister_WMDE mentioned this in rWDQG5222a92148b2: Refactor editor placeholder translation setup.
Lucas_Werkmeister_WMDE mentioned this in rWDQGccda79a59fa3: Refactor editor placeholder translation setup.
Smalyshev mentioned this in rWDQGb1b825c40771: Refactor editor placeholder translation setup.Nov 22 2018, 12:51 AM
gerritbot added a comment.Nov 22 2018, 12:53 AM

Change 472141 merged by jenkins-bot:
[wikidata/query/gui@master] Refactor editor placeholder translation setup

https://gerrit.wikimedia.org/r/472141

gerritbot added a comment.Nov 22 2018, 12:55 AM

Change 475254 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from b1b825c40771891b8cb47dc6a3ca838d182efa70:

https://gerrit.wikimedia.org/r/475254

gerritbot added a comment.Nov 22 2018, 1:02 AM

Change 475254 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from b1b825c40771891b8cb47dc6a3ca838d182efa70:

https://gerrit.wikimedia.org/r/475254

Shreyasminocha closed this task as Resolved.Dec 12 2018, 6:05 PM

Was fixed during GCI.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL