Page MenuHomePhabricator

Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler
Closed, ResolvedPublic

Description

Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler :

Review the code and add test coverage where possible. Current statement coverage is 63.27% (62/98).

Event Timeline

marcella triaged this task as Normal priority.Oct 15 2018, 7:38 PM
marcella created this task.
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Change 468303 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] LinearDeleteKeyDownHandler: Test delete next to link

https://gerrit.wikimedia.org/r/468303

Change 468712 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] LinearDeleteKeyDownHandler: Test shift+delete

https://gerrit.wikimedia.org/r/468712

Coverage is at 90/98 (91.84%) after the above two patches.

Change 468712 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearDeleteKeyDownHandler: Test shift+delete

https://gerrit.wikimedia.org/r/468712

Change 468303 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearDeleteKeyDownHandler: Test delete next to link

https://gerrit.wikimedia.org/r/468303

Change 469038 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b2ece1abc)

https://gerrit.wikimedia.org/r/469038

Change 469038 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c288b44f)

https://gerrit.wikimedia.org/r/469038

Can we add a screenshot here of the new test coverage, so that it can be compared to the old test coverage in the description? I don't know where the test coverage dashboard shown here lives, so I can't do that myself.

Deskana closed this task as Resolved.Nov 1 2018, 11:27 AM

Cool, thanks! That looks like a good enough improvement to call this resolved.