Page MenuHomePhabricator
Create Task
Maniphest T207079

Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler
Closed, ResolvedPublic
Actions

Description

Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler :

Review the code and add test coverage where possible. Current statement coverage is 76.34% (71/93).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (6c288b44f)mediawiki/extensions/VisualEditormaster+22 -9
LinearEnterKeyDownHandler: Add more testsVisualEditor/VisualEditormaster+28 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• marcella renamed this task from Increase unit test coverage in vve.ce.LinearEnterKeyDownHandler to Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler.Oct 15 2018, 7:40 PM
• marcella triaged this task as Medium priority.
• marcella created this task.
Esanders claimed this task.Oct 20 2018, 3:01 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Oct 20 2018, 3:02 PM

Change 468715 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] LinearEnterKeyDownHandler: Add more tests

https://gerrit.wikimedia.org/r/468715

gerritbot added a project: Patch-For-Review.Oct 20 2018, 3:03 PM
Esanders added a comment.Oct 20 2018, 3:03 PM

Increases to 77/93 (82.8%) after the above patch.

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Oct 20 2018, 4:12 PM
gerritbot added a comment.Oct 21 2018, 12:47 PM

Change 468715 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinearEnterKeyDownHandler: Add more tests

https://gerrit.wikimedia.org/r/468715

gerritbot added a comment.Oct 22 2018, 5:26 PM

Change 469038 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b2ece1abc)

https://gerrit.wikimedia.org/r/469038

gerritbot added a comment.Oct 23 2018, 7:42 PM

Change 469038 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c288b44f)

https://gerrit.wikimedia.org/r/469038

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Oct 23 2018, 7:56 PM
Jdforrester-WMF edited projects, added VisualEditor-ContentEditable, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30); removed Patch-For-Review.
Jdforrester-WMF subscribed.

Now at 90.22% (83/92). Is that good enough?

• Deskana subscribed.EditedOct 31 2018, 1:28 PM

Can we add some screenshots here of the new test coverage, so that it can be compared to the old test coverage in the description? I don't know where the test coverage dashboard shown here lives, so I can't do that myself.

matmarex added a comment.Nov 1 2018, 1:41 AM

https://doc.wikimedia.org/cover/visualeditor/src/ce/keydownhandlers/ve.ce.LinearEnterKeyDownHandler.js.html
Current statement coverage is 90.22%.

• Deskana closed this task as Resolved.Nov 1 2018, 11:27 AM

Cool, thanks! That looks like a good enough improvement to call this resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL