Page MenuHomePhabricator
Create Task
Maniphest T207083

Investigation spike to add test coverage for ve.ce.FocusableNode
Closed, ResolvedPublic
Actions

Description

Investigate the possibility of adding testing coverage. Current statement coverage is 63.1% (171/271).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (6c288b44f)mediawiki/extensions/VisualEditormaster+22 -9
Basic tests for getClientRects in ve.ce.Selection and FocusableNodeVisualEditor/VisualEditormaster+97 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• marcella triaged this task as Medium priority.Oct 15 2018, 7:51 PM
• marcella created this task.
gerritbot subscribed.Oct 22 2018, 12:32 PM

Change 468962 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Basic tests for getClientRects in ve.ce.Selection and FocusableNode

https://gerrit.wikimedia.org/r/468962

gerritbot added a project: Patch-For-Review.Oct 22 2018, 12:32 PM
gerritbot added a comment.Oct 22 2018, 5:29 PM

Change 468962 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Basic tests for getClientRects in ve.ce.Selection and FocusableNode

https://gerrit.wikimedia.org/r/468962

gerritbot added a comment.Oct 23 2018, 6:49 PM

Change 469038 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c288b44f)

https://gerrit.wikimedia.org/r/469038

gerritbot added a comment.Oct 23 2018, 7:42 PM

Change 469038 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c288b44f)

https://gerrit.wikimedia.org/r/469038

Jdforrester-WMF edited projects, added VisualEditor-ContentEditable, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30); removed Patch-For-Review.Oct 23 2018, 8:00 PM
Jdforrester-WMF subscribed.

Now at 71.59% (194/271). Is that good enough?

matmarex reassigned this task from matmarex to Esanders.Oct 23 2018, 8:46 PM

(Looks like Ed has taken this over from me, I haven't even looked into it.)

Esanders moved this task from Incoming to Engineering QA on the VisualEditor (Current work) board.Nov 7 2018, 7:20 PM
matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Nov 8 2018, 7:39 PM
• marcella closed this task as Resolved.Nov 19 2018, 7:34 PM

Coverage is currently at 73.43% (199/271).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL