Maniphest T207112

session_id(): Cannot change session id when session is active test failures on PHP 7.3
Closed, ResolvedPublic
Actions

Description

18:30:53 1) MediaWiki\Session\SessionBackendTest::testUnpersistOfGlobalSession
18:30:53 session_id(): Cannot change session id when session is active
18:30:53 
18:30:53 /workspace/src/tests/phpunit/includes/session/SessionBackendTest.php:945
18:30:53 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
18:30:53 /workspace/src/maintenance/doMaintenance.php:94
18:30:53 
18:30:53 2) MediaWiki\Session\SessionManagerTest::testGetGlobalSession
18:30:53 session_id(): Cannot change session id when session is active
18:30:53 
18:30:53 /workspace/src/tests/phpunit/includes/session/SessionManagerTest.php:85
18:30:53 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
18:30:53 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php73-docker/5/console

Details

	Subject	Repo	Branch	Lines +/-
	Add session_write_close() calls to SessionManager tests	mediawiki/core	REL1_31	+2 -0
	Add session_write_close() calls to SessionManager tests	mediawiki/core	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T204884 Run MediaWiki tests on PHP 7.3
		Resolved		Anomie	T207112 session_id(): Cannot change session id when session is active test failures on PHP 7.3

Event Timeline

Legoktm created this task.Oct 16 2018, 1:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2018, 1:37 AM

Legoktm moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.Oct 16 2018, 2:56 AM

Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 16 2018, 6:07 AM

Anomie claimed this task.Oct 16 2018, 2:24 PM

Anomie added a project: Platform Team Workboards (Waiting for Review).

Change 467695 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Add session_write_close() calls to SessionManager tests

https://gerrit.wikimedia.org/r/467695

gerritbot added a project: Patch-For-Review.Oct 16 2018, 2:24 PM

Change 467695 merged by jenkins-bot:
[mediawiki/core@master] Add session_write_close() calls to SessionManager tests

https://gerrit.wikimedia.org/r/467695

Change 467725 had a related patch set uploaded (by Legoktm; owner: Anomie):
[mediawiki/core@REL1_31] Add session_write_close() calls to SessionManager tests

https://gerrit.wikimedia.org/r/467725

Legoktm closed this task as Resolved.Oct 16 2018, 4:12 PM

Legoktm added a project: Platform Engineering (PHP7 (TEC4)).

Change 467725 merged by jenkins-bot:
[mediawiki/core@REL1_31] Add session_write_close() calls to SessionManager tests

https://gerrit.wikimedia.org/r/467725

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 16 2018, 5:01 PM

CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Nov 5 2018, 9:49 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM