Maniphest T207117

magic-export.php triggers warnings on PHP 7.3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 16 2018, 2:47 AM

Description

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /srv/mediawiki/core/extensions/Translate/scripts/magic-export.php on line 124
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /srv/mediawiki/core/extensions/Translate/scripts/magic-export.php on line 130

Details

	Subject	Repo	Branch	Lines +/-
	Replace continue with continue 2 inside switch statement	mediawiki/extensions/Translate	master	+2 -2

Customize query in gerrit

Event Timeline

Legoktm created this task.Oct 16 2018, 2:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2018, 2:47 AM

Legoktm moved this task from Backlog to Wikimedia production on the PHP 7.3 support board.Oct 16 2018, 2:56 AM

Alas, this script is currently not in use.

Change 500175 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Translate@master] Replace continue with continue 2 inside switch statement

https://gerrit.wikimedia.org/r/500175

gerritbot added a project: Patch-For-Review.Mar 30 2019, 12:29 PM

Daimona claimed this task.Mar 30 2019, 12:29 PM

Change 500175 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Replace continue with continue 2 inside switch statement

https://gerrit.wikimedia.org/r/500175

Daimona closed this task as Resolved.Apr 2 2019, 6:17 PM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 2 2019, 7:01 PM