Page MenuHomePhabricator
Create Task
Maniphest T207123

[AzharAuth] AzharAuth/AzharAuth.class.php triggers warnings on PHP 7.3
Closed, ResolvedPublic
Actions

Description

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /srv/mediawiki/core/extensions/AzharAuth/AzharAuth.class.php on line 285

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use `break` instead of `continue` in a switch block星耀晨曦mediawiki/extensions/AzharAuthmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Oct 16 2018, 2:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2018, 2:52 AM
Legoktm moved this task from Backlog to Other on the PHP 7.3 support board.Oct 16 2018, 2:56 AM
Liuxinyu970226 added a subscriber: Dereckson.Oct 16 2018, 1:28 PM
Liuxinyu970226 subscribed.

This extension is considering for archival per T198601, still need patch for this?

Legoktm added a comment.Oct 16 2018, 3:44 PM
In T207123#4670498, @Liuxinyu970226 wrote:

This extension is considering for archival per T198601, still need patch for this?

If the extension is archived, we can decline this. However I wanted to file tickets for everything as reference.

gerritbot added a comment.May 28 2019, 3:21 PM

Change 512916 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/AzharAuth@master] Use break instead of continue in a switch block

https://gerrit.wikimedia.org/r/512916

gerritbot added a project: Patch-For-Review.May 28 2019, 3:21 PM
RazeSoldier claimed this task.May 28 2019, 3:22 PM
gerritbot added a comment.May 29 2019, 1:45 AM

Change 512916 merged by jenkins-bot:
[mediawiki/extensions/AzharAuth@master] Use break instead of continue in a switch block

https://gerrit.wikimedia.org/r/512916

Maintenance_bot removed a project: Patch-For-Review.May 29 2019, 2:10 AM
RazeSoldier closed this task as Resolved.May 29 2019, 2:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits