Page MenuHomePhabricator

"Reset changes?" Text should only appear if something was changed
Closed, ResolvedPublic5 Estimate Story Points

Description

In TwoColConflict go to the editmode of some selected paragraph, and without changing anything click the Cancle/Reset-Icon.
You will be promted with the Text "Änderungen verwerfen? Dein Text wird auf den Zeitpunkt zurückgesetzt, an dem der Bearbeitungskonflikt aufgetreten ist."

Since you did not change anything, the text is confusing and unnecessary. Analogously to the normal editor you should only get a warning if you did change anything.

Details

Related Gerrit Patches:
mediawiki/extensions/TwoColConflict : masterAvoid duplicate jQuery selectors on reset
mediawiki/extensions/TwoColConflict : masterOnly ask to reset changes if there are any

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptOct 16 2018, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
WMDE-Fisch set the point value for this task to 5.Mon, Feb 10, 11:02 AM

Change 571694 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Only ask to reset changes if there are any

https://gerrit.wikimedia.org/r/571694

Change 572849 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Avoid duplicate jQuery selectors on reset

https://gerrit.wikimedia.org/r/572849

Change 571694 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Only ask to reset changes if there are any

https://gerrit.wikimedia.org/r/571694

WMDE-Fisch closed this task as Resolved.Tue, Feb 18, 12:58 PM
WMDE-Fisch moved this task from Doing to Demo on the WMDE-QWERTY-Sprint-2020-02-04 board.
WMDE-Fisch moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-04 board.

Change 572849 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Avoid duplicate jQuery selectors on reset

https://gerrit.wikimedia.org/r/572849