Maniphest T207186

$wgTemplateStylesNamespaces cannot be correctly set in LocalSettings.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Oct 16 2018, 3:26 PM

Description

Attempting to set $wgTemplateStylesNamespaces in LocalSettings.php results in a broken setting

>>> $wgTemplateStylesNamespaces
=> [
     true,
     true,
   ]

This seems to be due to it using the default "array_merge" merge strategy where it should probably use "array_plus"

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/TemplateStyles	master	+53 -33	Upgrade extension.json to version 2 and add merge strategy for $wgTemplateStylesNamespaces

Customize query in gerrit

Related Objects

Mentioned In: rETST7e1afddc3d7a: Upgrade extension.json to version 2 and add merge strategy for…

Event Timeline

Anomie created this task.Oct 16 2018, 3:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2018, 3:26 PM

Change 467718 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/TemplateStyles@master] Upgrade extension.json to version 2 and add merge strategy for $wgTemplateStylesNamespaces

https://gerrit.wikimedia.org/r/467718

gerritbot added a project: Patch-For-Review.Oct 16 2018, 3:27 PM

Anomie added a project: Platform Team Workboards (Waiting for Review).Oct 16 2018, 3:28 PM

Anomie mentioned this in rETST7e1afddc3d7a: Upgrade extension.json to version 2 and add merge strategy for….Oct 16 2018, 3:36 PM

Change 467718 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Upgrade extension.json to version 2 and add merge strategy for $wgTemplateStylesNamespaces

https://gerrit.wikimedia.org/r/467718

MGChecker closed this task as Resolved.Oct 16 2018, 4:15 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 16 2018, 5:01 PM

CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Nov 5 2018, 9:49 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:14 PM