Page MenuHomePhabricator

Backport codesniffer update to 19.x for PHP 7.3 compatibility
Closed, ResolvedPublic

Description

The 19.x release of codesniffer was intended for people who wanted to keep 5.5+ support. Except it's using an older version of upstream codesniffer which triggers warnings on PHP 7.3.

https://github.com/squizlabs/PHP_CodeSniffer/pull/2086

We'll need to tag a 19.0.1 with a bumped version.

Event Timeline

Change 469147 had a related patch set uploaded (by Legoktm; owner: Reedy):
[mediawiki/tools/codesniffer@19.x] Upgrade squizlabs/php_codesniffer to 3.3.1

https://gerrit.wikimedia.org/r/469147

Change 469149 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@19.x] Release 19.1.0

https://gerrit.wikimedia.org/r/469149

Change 469147 merged by jenkins-bot:
[mediawiki/tools/codesniffer@19.x] Upgrade squizlabs/php_codesniffer to 3.3.1

https://gerrit.wikimedia.org/r/469147

Change 469149 merged by jenkins-bot:
[mediawiki/tools/codesniffer@19.x] Release 19.1.0

https://gerrit.wikimedia.org/r/469149

New version released, and submitted patches to upgrade all repositories I found via codesearch.