For example:
20:32:51 wmf-style: total violations delta 3 20:32:51 NEW violations: 20:32:51 modules/profile/manifests/mail/smarthost.pp:29 wmf-style: Parameter 'facts['hostname']' of class 'profile::mail::smarthost' has no call to hiera 20:32:51 modules/profile/manifests/mail/smarthost.pp:30 wmf-style: Parameter 'facts['fqdn']' of class 'profile::mail::smarthost' has no call to hiera 20:32:51 modules/profile/manifests/mail/smarthost.pp:31 wmf-style: Parameter 'network::constants::production_networks' of class 'profile::mail::smarthost' has no call to hiera
class profile::mail::smarthost ( $prometheus_nodes = hiera('prometheus_nodes', []), $dkim_domains = hiera('profile::mail::smarthost::dkim_domains', []), $cert_name = hiera('profile::mail::smarthost::cert_name', $facts['hostname']), $cert_subjects = hiera('profile::mail::smarthost::cert_subjects', $facts['fqdn']), $relay_from_hosts = hiera('profile::mail::smarthost::relay_from_hosts', $network::constants::production_networks), $envelope_rewrite_rules = hiera('profile::mail::smarthost::envelope_rewrite_rules', []), $root_alias_rcpt = hiera('profile::mail::smarthost::root_alias_rcpt', 'root@wikimedia.org'), )
Spoke with @Joe on IRC who confirmed this is a bug.