Page MenuHomePhabricator
Create Task
Maniphest T207287

Separate *KeyDownHandler tests into separate files
Closed, ResolvedPublic
Actions

Description

ve.ce.surface.test.js is far too big. We fixed ve.ce.surface a while ago by moving key handler code into separate files, we should do the same for the tests.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (6cedee5ff)mediawiki/extensions/VisualEditormaster+1 -1
Move *KeyDownHandler tests into separate filesVisualEditor/VisualEditormaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Oct 17 2018, 2:57 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Oct 17 2018, 2:57 PM

Change 467989 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Move *KeyDownHandler tests into separate files

https://gerrit.wikimedia.org/r/467989

gerritbot added a project: Patch-For-Review.Oct 17 2018, 2:57 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Oct 17 2018, 2:57 PM
gerritbot added a comment.Oct 18 2018, 2:30 AM

Change 467989 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Move *KeyDownHandler tests into separate files

https://gerrit.wikimedia.org/r/467989

matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Oct 18 2018, 2:40 AM

(No QA needed)

matmarex closed this task as Resolved.Oct 18 2018, 2:40 AM

Actually, I don't think product review is needed for this change, either :)

gerritbot added a comment.Oct 18 2018, 11:24 PM

Change 468491 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6cedee5ff)

https://gerrit.wikimedia.org/r/468491

gerritbot added a comment.Oct 19 2018, 1:55 AM

Change 468491 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6cedee5ff)

https://gerrit.wikimedia.org/r/468491

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 19 2018, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL