Maniphest T20735

Cleanup Collection.hooks.php (patch)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 9 2009, 4:42 PM

Description

Author: happy.melon.wiki

Description:
against r50336, refactors collection.hooks.php

While effective and functional, this code is not as well integrated with MediaWiki's coding conventions or architecture as it could/should be. This patched version is, I hope, more so. I've cleaned up some unused variables and globals, rewritten the hardcoded HTML output to use Xml::tags(), Linker::link() and $wgOut->addScriptFile(), and fixed some double escaping in the tooltips (bug18719, thanks to Niklas Laxström for pointing that one out). I confess I'm not 100% certain I've got the script loads correct, as I'm not entirely sure what script does what. Everything I tested worked as it should :D

Version: unspecified
Severity: enhancement

Attached:

diff.txt15 KBDownload

Details

Reference: bz18735

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:35 PM

• bzimport added a project: Collection.

• bzimport set Reference to bz18735.

• bzimport created this task.May 9 2009, 4:42 PM

development wrote:

Thanks a lot. Reviewed and applied in http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=50472

I've had to add some additional calls to urldecode(). (I guess that's a good thing, because some URLs weren't encoded correctly before, but why doesn't the WebRequest class automatically do the decoding for me? Anyway...)

Cleanup Collection.hooks.php (patch)Closed, ResolvedPublicActions

Description

Details

Event Timeline

Cleanup Collection.hooks.php (patch)
Closed, ResolvedPublic
Actions