Page MenuHomePhabricator

Entity suggestions from constraint definitions are not linked
Closed, ResolvedPublic5 Story Points

Description

Problem:
We have a beta feature to give better value suggestions for properties that usually only use a small set of values like "sex and gender" or "driving side". Based on the on-of constraint defined on the property we show the expected value immediately in the value suggester.
Usually when middle-clicking on an entity in an entity selector it opens the entity in a new tab. (This is important if for some reason you are not sure if you have the right one and you want to investigate before choosing the entity and saving the edit.)
This behavior does not work for the suggestions from the beta feature.

Example:

Acceptance criteria:

  • middle-clicking on the value suggestions opens the entity in a new tab

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 8:44 AM
Lydia_Pintscher triaged this task as Normal priority.Apr 10 2019, 8:32 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
WMDE-leszek updated the task description. (Show Details)Apr 10 2019, 1:14 PM
WMDE-leszek set the point value for this task to 5.

Change 502821 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add URL to constraint suggestions

https://gerrit.wikimedia.org/r/502821

@Lydia_Pintscher is it acceptable if the link points to Special:EntityPage/ID (which redirects to the right page) instead of the right page directly? It looks like getting the correct link (even on wikis where items are in other namespaces) isn’t easy. (FWIW, Special:EntityPage is also the target of the “Wikidata item” links on client wikis.)

Yeah I think that's ok.

Change 502821 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add URL to constraint suggestions

https://gerrit.wikimedia.org/r/502821