Maniphest T207363

Entity suggestions from constraint definitions are not linked
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
We have a beta feature to give better value suggestions for properties that usually only use a small set of values like "sex and gender" or "driving side". Based on the on-of constraint defined on the property we show the expected value immediately in the value suggester.
Usually when middle-clicking on an entity in an entity selector it opens the entity in a new tab. (This is important if for some reason you are not sure if you have the right one and you want to investigate before choosing the entity and saving the edit.)
This behavior does not work for the suggestions from the beta feature.

Example:

enable beta feature "Entity suggestions from constraint definitions" on https://www.wikidata.org/wiki/Special:Preferences#mw-prefsection-betafeatures
start creating a new statement with property "driving side"
see value suggestions "left" and "right"
middle-click on one of the value suggestions
see that nothing happens

Acceptance criteria:

middle-clicking on the value suggestions opens the entity in a new tab

Details

	Subject	Repo	Branch	Lines +/-
	Add URL to constraint suggestions	mediawiki/extensions/WikibaseQualityConstraints	master	+14 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lucas_Werkmeister_WMDE	T209879 Graduate suggestions based on constraints beta feature out of beta features
		Resolved		Lucas_Werkmeister_WMDE	T207363 Entity suggestions from constraint definitions are not linked

Event Timeline

Sjoerddebruin created this task.Oct 18 2018, 8:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 8:44 AM

Sjoerddebruin added a parent task: T209879: Graduate suggestions based on constraints beta feature out of beta features.Mar 11 2019, 1:35 PM

Lea_Lacroix_WMDE subscribed.Mar 13 2019, 8:45 AM

Lea_Lacroix_WMDE added a project: Wikidata-Campsite.Mar 25 2019, 11:42 AM

Lea_Lacroix_WMDE mentioned this in T209879: Graduate suggestions based on constraints beta feature out of beta features.

Lydia_Pintscher triaged this task as Medium priority.Apr 10 2019, 8:32 AM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

WMDE-leszek updated the task description. (Show Details)Apr 10 2019, 1:14 PM

WMDE-leszek set the point value for this task to 5.

WMDE-leszek moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Apr 10 2019, 1:49 PM

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Lucas_Werkmeister_WMDE claimed this task.Apr 10 2019, 2:47 PM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 502821 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add URL to constraint suggestions

https://gerrit.wikimedia.org/r/502821

gerritbot added a project: Patch-For-Review.Apr 10 2019, 3:44 PM

@Lydia_Pintscher is it acceptable if the link points to Special:EntityPage/ID (which redirects to the right page) instead of the right page directly? It looks like getting the correct link (even on wikis where items are in other namespaces) isn’t easy. (FWIW, Special:EntityPage is also the target of the “Wikidata item” links on client wikis.)