Page MenuHomePhabricator
Create Task
Maniphest T207382

[BUG] Login status incorrect when changing password (or when cookies expire)
Closed, ResolvedPublic
Actions

Assigned To
• NHarateh_WMF
Authored By
JoeWalsh
Oct 18 2018, 12:08 PM
Tags
Referenced Files
F27244726: IMG_0085.PNG
Nov 16 2018, 7:37 PM
F27244724: Image-1 (2).jpg
Nov 16 2018, 7:37 PM
F27222160: Simulator Screen Shot - iPhone X - 2018-11-14 at 13.57.49.png
Nov 14 2018, 8:14 PM
F27222814: Simulator Screen Shot - iPhone X - 2018-11-14 at 15.12.33.png
Nov 14 2018, 8:14 PM
F27222829: Simulator Screen Shot - iPhone X - 2018-11-14 at 15.13.58.png
Nov 14 2018, 8:14 PM
F27221014: keepSavedArticles.png
Nov 14 2018, 4:53 PM
F27219560: IMG_EE894C20B06C-1.jpeg
Nov 14 2018, 3:36 PM
F27020679: Auth issue warning.png
Nov 2 2018, 4:58 PM
Subscribers
ABorbaWMF
Aklapper
cmadeo
• JMinor
JoeWalsh
Tokens
"Burninate" token, awarded by JMinor.

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. Login to the app with an account
  2. Change the same accounts password on the web (invalidates all sessions)
  3. Go to settings

Expected results

After an authenticated request fails (30-60 seconds if you have reading list sync enabled) "Log in" is shown, indicating the user is logged out

We should also discuss if we want to post an error message when this occurs.

Actual results

User name is still visible

Environments observed

App version: 6.0.2

Mocks

Auth issue warning.png (1×750 px, 128 KB)
Zeplin: https://zpl.io/Vx1vK6R

Copy

TitleBodyCTAClose link text
You have been logged outThere was a problem authenticating your account. In order to sync your reading lists and edit under your user name please log back in.Log back in to your accountContinue without logging in

Related Objects

Event Timeline

JoeWalsh created this task.Oct 18 2018, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2018, 12:08 PM
JoeWalsh added a project: iOS-app-v6.1-Narwhal-On-A-Bumper-Car.Oct 18 2018, 1:15 PM
JoeWalsh moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v6.1-Narwhal-On-A-Bumper-Car board.Oct 18 2018, 6:54 PM
JoeWalsh edited projects, added iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin; removed iOS-app-v6.1-Narwhal-On-A-Bumper-Car.
JoeWalsh triaged this task as Medium priority.Oct 24 2018, 5:26 PM
JoeWalsh moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Oct 29 2018, 6:46 PM
• JMinor subscribed.Nov 1 2018, 6:54 PM
  • This occurs for multiple stories, so solution needs to be generic for any scenario where the user is logged out not of their own volition.
  • Do we want to notify users if this occurs? Pop-up, alert, or indicator on the log-in screen?
cmadeo updated the task description. (Show Details)Nov 2 2018, 4:58 PM
cmadeo moved this task from Needs Design to Needs Acceptance Criteria on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.
• NHarateh_WMF claimed this task.Nov 2 2018, 6:25 PM
Diffusion mentioned this in rAPIOS0fa99fba6914: Merge branch 'develop' into bug/T207382.Nov 3 2018, 4:20 PM
JoeWalsh mentioned this in rAPIOS64ef79100419: Merge branch 'develop' into bug/T207382.Nov 5 2018, 12:12 PM
Diffusion mentioned this in rAPIOS1a0192f8711d: Merge branch 'develop' into bug/T207382.Nov 5 2018, 2:35 PM
• JMinor moved this task from Needs Acceptance Criteria to Doing on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 5 2018, 7:34 PM
JoeWalsh mentioned this in rAPIOS5a6e054895f3: Merge branch 'develop' into bug/T207382.Nov 5 2018, 8:07 PM
• NHarateh_WMF mentioned this in rAPIOS4423f889ca91: Merge branch 'develop' into bug/T207382.Nov 5 2018, 9:26 PM
• NHarateh_WMF mentioned this in rAPIOS4df75478983f: Merge branch 'bug/T207382' of https://github.com/wikimedia/wikipedia-ios into….
JoeWalsh mentioned this in rAPIOS0fe0e663be4c: Merge branch 'develop' into bug/T207382.Nov 6 2018, 3:54 PM
• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 6 2018, 7:15 PM
JoeWalsh mentioned this in rAPIOS1cc9cc99e51d: Merge pull request #2743 from wikimedia/bug/T207382.Nov 6 2018, 8:09 PM
• NHarateh_WMF moved this task from Needs Code Review to Needs Design Review on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 7 2018, 3:25 PM
cmadeo subscribed.Nov 14 2018, 3:36 PM

IMG_EE894C20B06C-1.jpeg (2×1 px, 665 KB)

@NHarateh_WMF this is working really well!
The second link text looks a bit far away from the primary CTA.

Can we have the second link be 10 pt below the CTA and 30pt from the bottom of the card? Also just double checking that it is using 13pt as the font size.

cmadeo moved this task from Needs Design Review to Blocked or Waiting on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 14 2018, 3:36 PM
• NHarateh_WMF added a comment.Nov 14 2018, 4:53 PM

@cmadeo it's using the same popover as "Keep saved articles on device?" and other popovers

keepSavedArticles.png (2×1 px, 255 KB)

Do you want to move all of the second links to be 10 pt below the CTA and 30pt from the bottom of the card? Right now there's 14pt of spacing between all the elements (image, title, subtitle, primary button, secondary button) and 18pt from the bottom

Looks like the font is 11pt (we're using the default Caption 2: https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/typography/) - do you want to use 13pt?

cmadeo added a comment.Nov 14 2018, 6:24 PM

Hi @NHarateh_WMF eep, sorry I should have caught this on another card. Would it be possible to make those updates now (13 pt and updated spacing?)

Thank you!

• NHarateh_WMF moved this task from Blocked or Waiting to Doing on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 14 2018, 6:35 PM

Sure, no problem @cmadeo!

• NHarateh_WMF added a comment.Nov 14 2018, 8:14 PM

@cmadeo this is what it looks like with 30pt spacing top & bottom, 10pt spacing between the CTA and the 2nd link and 13pt font for the 2nd link

Simulator Screen Shot - iPhone X - 2018-11-14 at 13.57.49.png (2×1 px, 249 KB)

👍 or different spacing?

This is what the "Keep saved articles on device?" looks like with the changes

Simulator Screen Shot - iPhone X - 2018-11-14 at 15.12.33.png (2×1 px, 554 KB)

and this is what panels would look like with footer text

Simulator Screen Shot - iPhone X - 2018-11-14 at 15.13.58.png (2×1 px, 293 KB)

cmadeo added a comment.Nov 14 2018, 8:48 PM

Looks great, thanks for the updates @NHarateh_WMF!

JoeWalsh mentioned this in rAPIOSbe7ef0412d6d: Merge pull request #2771 from wikimedia/update/T207382.Nov 14 2018, 10:45 PM
• NHarateh_WMF moved this task from Doing to Waiting for Build on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 14 2018, 11:34 PM
• JMinor moved this task from Waiting for Build to Needs QA on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 15 2018, 8:02 PM
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.1.1-Narwhal-On-A-Magic-Pumpkin board.Nov 16 2018, 7:37 PM
ABorbaWMF subscribed.

Looks good to me on 6.1.1 (1527)

Image-1 (2).jpg (2×1 px, 282 KB)

IMG_0085.PNG (2×1 px, 1 MB)

• JMinor closed this task as Resolved.Dec 3 2018, 7:27 PM
• JMinor awarded a token.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL