I don't see any visibiliy indicators in the screenshots, and hte before/after screenshots seem identical to me.

Change 982153 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[jsdoc/wmf-theme@master] Make attributes (static, protected) more visually distinct

https://gerrit.wikimedia.org/r/982153

I think this is a lot better @AnneT .

I do wonder if we should move the chips to their own line. Maybe above the function name ? That might require redoing that entire block with the hide/show with some flex box magic however.

In T207384#9397767, @AnneT wrote:

Are there other indicators we should account for?

I also found: nullable https://doc.wikimedia.org/TimedMediaHandler/master/js/js/MediaElement.html

Thanks @TheDJ!

In T207384#9399410, @TheDJ wrote:

I also found: nullable https://doc.wikimedia.org/TimedMediaHandler/master/js/js/MediaElement.html

I looked through some more repositories and also found inner and constant. I think the design decision here is: which attributes, if any, should be distinguished via different colors? Just protected and private? I've also played around with making static look more...static:

But I'm not sure it really needs to be distinct from other attributes like nullable:

I do wonder if we should move the chips to their own line. Maybe above the function name ? That might require redoing that entire block with the hide/show with some flex box magic however.

I gave this a shot - it makes the tags much more prominent, but increases the space taken up by each accordion section. What do you think?

I also tried putting the tags on the end of the line:

screenshot of static pill in jsduck

@TheDJ nice - so perhaps it is helpful to have static be distinguished from other things.

@egardner made the following suggestions:

• Put the tags either above or after the signature so the member/method names are more easily scannable
• Make static, protected, and private the same color. This highlights them against the other attributes, but doesn't distinguish them from each other, which makes sense (using warning and error colors for them gave them unnecessary meaning)

I've made these updates in my patch, which now results in this:

In T207384#9401419, @AnneT wrote:

@egardner made the following suggestions:

• Put the tags either above or after the signature so the member/method names are more easily scannable
• Make static, protected, and private the same color. This highlights them against the other attributes, but doesn't distinguish them from each other, which makes sense (using warning and error colors for them gave them unnecessary meaning)

I've made these updates in my patch, which now results in this:

Thanks, Anne. I think we can always introduce further refinements later but I believe this is a good update for now.

Change 982153 merged by jenkins-bot:

[jsdoc/wmf-theme@master] Make attributes (static, protected) more visually distinct

https://gerrit.wikimedia.org/r/982153

We've gone with the design in my last comment for now; please open a new task if you'd like to suggest changes or improvements!