Page MenuHomePhabricator
Create Task
Maniphest T207416

Upgrade Puppeteer to 1.9.0
Closed, ResolvedPublic
Actions

Description

New puppeteer version available: 1.8.0 - There are some changes for js response handling permissions, mocking geolocationApi and adding referrer as an argument. More detailed change log is available on 1.8.0 release page

Most important - we could use is PUPPETEER_EXECUTABLE_PATH that can override the path to the chromium executable. We could drop our CHROME_BIN environment variable.

There is a patch in flight Version 1.8.0 will be merged once we find out whats causing Puppeteer to stop sending Host header, most probably we will downgrade puppeteer lib to 1.6.0 for now (as this is last know version that didn't cause missing Host header issues.

Update: There is 1.9.0

Details

SubjectRepoBranchLines +/-
Update puppeteer to latest 1.9.0mediawiki/services/chromium-rendermaster+22 -14
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedovasilevaT181079 [GOAL] Provide an expanded reading experience by improving the ways that users can download articles of interest for later consumption
 ResolvedNoneT181084 [EPIC] Deploy the mediawiki-services-chromium-render service (Proton)
 ResolvedBawolffT177765 Security review of mediawiki-services-chromium-render
 ResolvedphuedxT178071 [EPIC] Complete the First Deployment tutorial/checklist for the trial render service
 Resolved• mobrovacT178168 Scap3ize the deploy repository
 Resolved• mobrovacT178172 Create Puppet role and profile
 ResolvedphuedxT181118 [EPIC] Build a Chromium-based PDF renderer service
 ResolvedJdrewniakT179552 Set up Jenkins for chromium-render repository
 ResolvedphuedxT180601 Add logging to the mediawiki-services-chromium-render service
 ResolvedphuedxT180626 [Spike 8hr] How should we limit resources used by chromium render service?
 ResolvedphuedxT178278 Performance test the service
 ResolvedphuedxT178501 Limit resources used by Chromium in order to make the chromium-render service ready for production
 DeclinedNoneT178186 Update Node.js version/dependencies in package.json
 Resolved• bmansurovT176627 Trial replacing Electron with headless Chromium in the render service
 Resolved• mobrovacT180800 Update to service-template-node v0.5.3
 ResolvedovasilevaT180604 Chromium render keeps tasks in the queue even browser connection is lost
 InvalidNoneT183161 Performance test books on chromium rendering service
 ResolvedJdlrobsonT184609 [4hrs] Document the service
 ResolvedphuedxT189307 Instrument the Proton service to match mediawiki-services-electron-render
 ResolvedphuedxT181097 Update puppeteer regularly
 Resolved• holger.knustT210651 Switch all PDF render traffic to new Proton service
 ResolvedTgrT213362 Limit what URLs Proton can access
 ResolvedjijikiT226675 Undeploy electron service from WMF production
 ResolvedMSantosT226677 Expand RESTBase public PDF rendering API to support additional options supported by Proton
 Resolved• mobrovacT197862 Increase the CPU count for proton[12]00[12]
 ResolvedovasilevaT210793 Verify that PDFs generated by Proton service are correct
 ResolvedphuedxT210652 Handoff Proton service to Reading Infrastructure
 DeclinedpmiazgaT211375 Rename chromium-render gerrit project to Proton
 ResolvedDzahnT211382 Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr
 ResolvedpmiazgaT213363 Fix or clarify Proton Puppeteer sandboxing and SSL settings
 Duplicate• holger.knustT215557 Remove electron pdf endpoint backend in RESTBase
 ResolvedMSantosT213366 [2 hrs] Decide on handling system updates for Proton
 ResolvedTgrT217724 Investigate 2019-03-01 Proton incident
 ResolvedJohanT220648 Communications plan for Electron -> Proton switchover
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 ResolvedovasilevaT163472 [EPIC] Provide a way to download articles in PDF on the mobile website
 InvalidNoneT181513 Prepare for deploy of chromium rendering service and usage on mobile (traffic)
 Resolved• mobrovacT186748 [EPIC] New service request: chromium-render/deploy
 ResolvedpmiazgaT207416 Upgrade Puppeteer to 1.9.0

Event Timeline

Jdlrobson triaged this task as High priority.Oct 18 2018, 8:23 PM
Jdlrobson created this task.
Restricted Application edited projects, added Services; removed Services (blocked). · View Herald TranscriptOct 18 2018, 8:23 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 8:23 PM
gerritbot added a comment.Oct 18 2018, 8:24 PM

Change 461366 had a related patch set uploaded (by Jdlrobson; owner: Pmiazga):
[mediawiki/services/chromium-render@master] Update puppeteer to latest 1.9.0

https://gerrit.wikimedia.org/r/461366

gerritbot added a project: Patch-For-Review.Oct 18 2018, 8:24 PM
Jdlrobson mentioned this in rMSCR6d731d0a8f49: Update puppeteer to latest 1.9.0.Oct 18 2018, 8:27 PM
• mobrovac edited projects, added Services (blocked); removed Services, User-notice, Service-deployment-requests, Electron-PDFs, SRE.Oct 19 2018, 11:19 AM
pmiazga mentioned this in rMSCRa2fb7d833579: Update puppeteer to latest 1.9.0.Oct 19 2018, 12:05 PM
pmiazga mentioned this in rMSCRb4a68ca6a3f4: Update puppeteer to latest 1.9.0.Oct 19 2018, 3:25 PM
pmiazga mentioned this in rMSCRe2de7f25c707: Update puppeteer to latest 1.9.0.Oct 19 2018, 4:29 PM
gerritbot added a comment.Oct 22 2018, 5:29 PM

Change 461366 merged by Mobrovac:
[mediawiki/services/chromium-render@master] Update puppeteer to latest 1.9.0

https://gerrit.wikimedia.org/r/461366

• mobrovac mentioned this in rMSCRcffdd7692069: Update puppeteer to latest 1.9.0.Oct 22 2018, 5:31 PM
Stashbot added a comment.Oct 22 2018, 5:38 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-22T17:38:45Z] <mobrovac@deploy1001> Started deploy [proton/deploy@b3e254a]: Update Puppeteer to v1.9.0 - T207416

Stashbot added a comment.Oct 22 2018, 5:40 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-22T17:40:19Z] <mobrovac@deploy1001> Finished deploy [proton/deploy@b3e254a]: Update Puppeteer to v1.9.0 - T207416 (duration: 01m 34s)

• mobrovac closed this task as Resolved.Oct 22 2018, 5:46 PM
• mobrovac edited projects, added Services (done); removed Services (blocked), Patch-For-Review.

New version deployed. No problems so far.

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 22 2018, 6:00 PM
Jdlrobson moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits