Page MenuHomePhabricator

Send Message to creator without needing to 'unreview'/'re-review' the article
Open, NormalPublic5 Story Points

Description

Value proposition

Currently the Send message for the creator and the Mark as reviewed processes are intertwined. A reviewer can only send a message to the creator if the page is not already reviewed. And the button to send message to creator also acts as a mark as reviewed button. These two workflows should be separated because often reviewers need to send a message to the creator without marking the page as reviewed (such as when it's still under review).

To-do:

  • When user hits Mark as reviewed, that only marks the page as reviewed and does not send message to creator.
  • Add a new button Send message to creator which sends a message to the page creator if there is text present in the textarea. The button is disabled if there is no text.
  • Position the elements according the mockup above (with a horizontal separator between the two different steps.
  • The checkmark on the tab turns green only if the page has been marked as reviewed (no relation to whether a message was sent to creator).

Notes:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2018, 8:23 AM

@Insertcleverphrasehere: Adding PageCuration project tag so this task can be found when looking at PageCuration tasks at https://phabricator.wikimedia.org/tag/mediawiki-extensions-pagecuration/ . No need to add team tags like Growth-Team; that is up to each team (or automatic filters).

JTannerWMF moved this task from Inbox to External on the Growth-Team board.Mar 19 2019, 6:07 PM
JTannerWMF added a subscriber: JTannerWMF.

It appears the CommTech team is working on this.

Niharika triaged this task as Normal priority.Mar 28 2019, 5:17 PM
Niharika updated the task description. (Show Details)
Niharika set the point value for this task to 5.Apr 25 2019, 5:12 PM
MusikAnimal moved this task from Ready to In Development on the Community-Tech-Sprint board.
Niharika changed the task status from Open to Stalled.May 1 2019, 8:43 PM

We've run into some questions for the community while working on this ticket. We're discussing them on the project page. This ticket is stalled until we have an answer.

@Niharika We might want to take this off the Sprint board until it's ready :)

Niharika changed the task status from Stalled to Open.May 14 2019, 3:31 PM

Looks like we have a decision. The template message is going to be review-agnostic. @MusikAnimal I think we can proceed on this task now, right?

MusikAnimal removed MusikAnimal as the assignee of this task.May 22 2019, 4:19 PM
MusikAnimal moved this task from In Development to Ready on the Community-Tech-Sprint board.
MusikAnimal added a subscriber: MusikAnimal.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban). · View Herald TranscriptTue, May 28, 3:58 PM
HMonroy claimed this task.Tue, Jun 11, 9:07 PM
HMonroy moved this task from Ready to In Development on the Community-Tech (Kanban) board.
HMonroy added a comment.EditedThu, Jun 20, 9:47 PM

@Niharika In the code, there was some previous functionality were if the article was marked as Reviewed the message was sent to the reviewer. I could see this behavior now that I'm always displaying the message box. Just to clarify, when the button says "Mark as Unreviewed" the message is also meant to be sent to the creator?

We discussed this in the meeting. Here's a summary:

  • The Review/Unreview and Send a message workflows should be completely decoupled.
  • The Send a message box is always there and the message is always sent to the creator
  • Unreviewing an article sends an automated message to the prior reviewer (This functionality remains unchanged)