Page MenuHomePhabricator
Create Task
Maniphest T207461

Validate DNS-01 challenges against every DNS server
Closed, ResolvedPublic
Actions

Description

Right now the code sets the DNS server list as the nameservers list to make one TXT query, so as long as one answers the challenge is going to be considered as valid. We need to loop and check each DNS server.

Details

ProjectBranchLines +/-Subject
operations/software/acme-chiefdebian+6 -0debian: Add release 0.16 to changelog
operations/software/acme-chiefdebian+2 -2Release 0.16
operations/software/acme-chiefdebian+112 -55acme_requests: Validate dns-01 challenges against all the DNS servers
operations/software/acme-chiefmaster+2 -2Release 0.16
operations/software/acme-chiefmaster+112 -55acme_requests: Validate dns-01 challenges against all the DNS servers
Customize query in gerrit

Related Objects

Event Timeline

Vgutierrez created this task.Oct 19 2018, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2018, 12:30 PM
Vgutierrez triaged this task as Medium priority.Oct 19 2018, 12:30 PM
Krenair added a subscriber: Krenair.Feb 22 2019, 12:41 PM

Dupe of T203396: certcentral: challenge checking on *all* pooled backend hosts ? Or not quite? Definitely related either way.

Vgutierrez claimed this task.Apr 10 2019, 3:04 PM
Vgutierrez raised the priority of this task from Medium to High.
Vgutierrez mentioned this in T219414: acme-chief fails to issue certificates against LE staging environment.
gerritbot added a comment.Apr 11 2019, 10:43 AM

Change 502965 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] acme_requests: Validate dns-01 challenges against all the DNS servers

https://gerrit.wikimedia.org/r/502965

gerritbot added a project: Patch-For-Review.Apr 11 2019, 10:43 AM
Vgutierrez mentioned this in rOSAC94faa1b2c996: acme_requests: Validate dns-01 challenges against all the DNS servers.Apr 11 2019, 12:14 PM
Vgutierrez mentioned this in rOSAC0f8ae91f7e61: acme_requests: Validate dns-01 challenges against all the DNS servers.
Vgutierrez mentioned this in rOSACc7d707122b25: acme_requests: Validate dns-01 challenges against all the DNS servers.Apr 11 2019, 1:56 PM
gerritbot added a comment.Apr 11 2019, 2:08 PM

Change 502965 merged by jenkins-bot:
[operations/software/acme-chief@master] acme_requests: Validate dns-01 challenges against all the DNS servers

https://gerrit.wikimedia.org/r/502965

gerritbot added a comment.Apr 11 2019, 2:12 PM

Change 503000 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] Release 0.15

https://gerrit.wikimedia.org/r/503000

Vgutierrez mentioned this in rOSAC336b26f2406e: Release 0.15.Apr 11 2019, 2:13 PM
Vgutierrez mentioned this in rOSAC1b9ce513d7ef: Release 0.16.Apr 11 2019, 2:18 PM
gerritbot added a comment.Apr 11 2019, 2:24 PM

Change 503000 merged by Vgutierrez:
[operations/software/acme-chief@master] Release 0.16

https://gerrit.wikimedia.org/r/503000

gerritbot added a comment.Apr 11 2019, 2:30 PM

Change 503005 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@debian] acme_requests: Validate dns-01 challenges against all the DNS servers

https://gerrit.wikimedia.org/r/503005

gerritbot added a comment.Apr 11 2019, 2:30 PM

Change 503006 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@debian] Release 0.16

https://gerrit.wikimedia.org/r/503006

gerritbot added a comment.Apr 11 2019, 2:32 PM

Change 503005 merged by Vgutierrez:
[operations/software/acme-chief@debian] acme_requests: Validate dns-01 challenges against all the DNS servers

https://gerrit.wikimedia.org/r/503005

gerritbot added a comment.Apr 11 2019, 2:32 PM

Change 503006 merged by Vgutierrez:
[operations/software/acme-chief@debian] Release 0.16

https://gerrit.wikimedia.org/r/503006

Vgutierrez mentioned this in rOSAC267463d32fdf: acme_requests: Validate dns-01 challenges against all the DNS servers.Apr 11 2019, 2:33 PM
Vgutierrez mentioned this in rOSACab936d77f339: Release 0.16.
gerritbot added a comment.Apr 11 2019, 2:34 PM

Change 503010 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@debian] debian: Add release 0.16 to changelog

https://gerrit.wikimedia.org/r/503010

gerritbot added a comment.Apr 11 2019, 2:37 PM

Change 503010 merged by jenkins-bot:
[operations/software/acme-chief@debian] debian: Add release 0.16 to changelog

https://gerrit.wikimedia.org/r/503010

Vgutierrez mentioned this in rOSACcefcf253ec24: debian: Add release 0.16 to changelog.Apr 11 2019, 2:38 PM
Vgutierrez closed this task as Resolved.Apr 11 2019, 3:21 PM
Vgutierrez removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL