Page MenuHomePhabricator
Create Task
Maniphest T207478

Avoid infinite attempts on issuing a certificate on permanent LE side errors
Closed, ResolvedPublic
Actions

Description

If for some reason LE rejects issuing a certificate on a semi-permanent basis (API rate limiting, CAA record misconfigured), it shouldn't retry every 5 seconds.

It should issue a warning and throttle the certificate issuance or disable it

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
debian: Add release 0.3 to changelogVgutierrezoperations/software/certcentraldebian+7 -0
Release 0.3Vgutierrezoperations/software/certcentraldebian+1 -1
certcentral: Track number of retries and apply exponential backoffVgutierrezoperations/software/certcentraldebian+163 -47
Release 0.3Vgutierrezoperations/software/certcentralmaster+1 -1
certcentral: Track number of retries and apply exponential backoffVgutierrezoperations/software/certcentralmaster+163 -47
Customize query in gerrit

Related Objects

Event Timeline

Vgutierrez created this task.Oct 19 2018, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2018, 3:08 PM
Krenair subscribed.Oct 19 2018, 3:08 PM
Vgutierrez triaged this task as Medium priority.Oct 23 2018, 8:42 AM
Vgutierrez mentioned this in T207737: LE rejects issuing two certificates with the same CSR on a short timespan.Oct 23 2018, 10:36 AM
Vgutierrez claimed this task.Oct 23 2018, 12:59 PM
gerritbot subscribed.Oct 24 2018, 10:28 AM

Change 469407 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@master] certcentral: Track number of retries and apply exponential backoff

https://gerrit.wikimedia.org/r/469407

gerritbot added a project: Patch-For-Review.Oct 24 2018, 10:28 AM
Vgutierrez mentioned this in rOSCCdcda1f4f54bb: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 10:37 AM
Vgutierrez mentioned this in rOSCCabfb3b4afd4a: certcentral: Track number of retries and apply exponential backoff.
Vgutierrez mentioned this in rOSCCdcae58dfc1f1: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 11:04 AM
Vgutierrez mentioned this in rOSCC9c9c92659bda: certcentral: Track number of retries and apply exponential backoff.
Vgutierrez mentioned this in rOSCC2e2ea5de81f8: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 2:06 PM
Vgutierrez mentioned this in rOSCCed30ed735704: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 4:30 PM
Vgutierrez mentioned this in rOSCCc11cb4f7d080: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 4:34 PM
gerritbot added a comment.Oct 24 2018, 4:36 PM

Change 469407 merged by Vgutierrez:
[operations/software/certcentral@master] certcentral: Track number of retries and apply exponential backoff

https://gerrit.wikimedia.org/r/469407

gerritbot added a comment.Oct 24 2018, 4:40 PM

Change 469459 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@master] Release 0.3 including the following changes:

https://gerrit.wikimedia.org/r/469459

Vgutierrez mentioned this in rOSCC582bda07b2ad: Release 0.3 including the following changes:.Oct 24 2018, 4:40 PM
Vgutierrez mentioned this in rOSCCc8254eed85d9: Release 0.3.Oct 24 2018, 4:44 PM
gerritbot added a comment.Oct 24 2018, 4:44 PM

Change 469459 merged by jenkins-bot:
[operations/software/certcentral@master] Release 0.3

https://gerrit.wikimedia.org/r/469459

gerritbot added a comment.Oct 24 2018, 4:47 PM

Change 469460 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] certcentral: Track number of retries and apply exponential backoff

https://gerrit.wikimedia.org/r/469460

gerritbot added a comment.Oct 24 2018, 4:47 PM

Change 469462 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] Release 0.3

https://gerrit.wikimedia.org/r/469462

Vgutierrez mentioned this in rOSCC574671e58dff: certcentral: Track number of retries and apply exponential backoff.Oct 24 2018, 4:49 PM
Vgutierrez mentioned this in rOSCCa912af2440ec: Release 0.3.
gerritbot added a comment.Oct 24 2018, 4:49 PM

Change 469460 merged by Vgutierrez:
[operations/software/certcentral@debian] certcentral: Track number of retries and apply exponential backoff

https://gerrit.wikimedia.org/r/469460

gerritbot added a comment.Oct 24 2018, 4:50 PM

Change 469462 merged by Vgutierrez:
[operations/software/certcentral@debian] Release 0.3

https://gerrit.wikimedia.org/r/469462

gerritbot added a comment.Oct 24 2018, 4:53 PM

Change 469464 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/certcentral@debian] debian: Add release 0.3 to changelog

https://gerrit.wikimedia.org/r/469464

Vgutierrez mentioned this in rOSCC3ad4be2a6b2c: debian: Add release 0.3 to changelog.Oct 24 2018, 4:54 PM
gerritbot added a comment.Oct 24 2018, 4:57 PM

Change 469464 merged by Vgutierrez:
[operations/software/certcentral@debian] debian: Add release 0.3 to changelog

https://gerrit.wikimedia.org/r/469464

Stashbot subscribed.Oct 25 2018, 7:16 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-25T07:16:28Z] <vgutierrez> Uploaded certcentral 0.3 to apt.wikimedia.org (stretch) - T207737 T207478

Krenair added a comment.Feb 22 2019, 12:44 PM

@Vgutierrez: is this done?

Vgutierrez closed this task as Resolved.Feb 22 2019, 1:12 PM

yeah, it was included as part of the 0.3 release

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits