Page MenuHomePhabricator
Create Task
Maniphest T207509

Wikipedia-Tag banner is breaking Wikipedia page layout
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

At least for Firefox on Windows 10, the banner is pushing down the edit tabs and the search box:

grafik.png (809×2 px, 256 KB)

On articles with geo coordinates, the map links are hidden:

grafik.png (812×1 px, 158 KB)

Event Timeline

Cirdan triaged this task as High priority.Oct 19 2018, 7:41 PM
Cirdan created this task.
Cirdan added a project: Wikimedia-Site-requests.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptOct 19 2018, 7:42 PM
Urbanecm removed a project: Wikimedia-Site-requests.Oct 19 2018, 8:02 PM
Urbanecm added a subscriber: Urbanecm.

I think this is not a site request, because it is technically implemented by using central notice feature, see the banner definition. Any requests regarding central notice banners or campaigns are solvable by on-wiki guys, namely central notice administrators and stewards. Please look through this page and pages linked from it if you want to know more.

I'm removing the site requests tag, as this is out of scope for this project. I'm not closing this as invalid, as it is tagged with a project that seems to be relevant.

Urbanecm removed a subscriber: Dereckson.Oct 19 2018, 8:02 PM
Cirdan added a comment.Oct 21 2018, 1:31 PM

@Urbanecm Sorry, I was trying to find the most appropriate tag for this as the banner is shown to a lot of visitors. Is there a CentralNotice tag for Phabricator?

Verena added a subscriber: Verena.Oct 22 2018, 9:12 AM
Verena added a subscriber: • Stefan_Schneider_WMDE.Oct 22 2018, 9:16 AM
Verena added a subscriber: sonkiki.Oct 22 2018, 9:18 AM
• Stefan_Schneider_WMDE added a subscriber: • Tim_WMDE.Oct 22 2018, 10:26 AM

Hi @Tim_WMDE,

is it possible to fix that?

Kindly,
Stefan

• Tim_WMDE claimed this task.Oct 22 2018, 1:28 PM
• Tim_WMDE added a project: WMDE-FUN-Sprint-2018-10-15.
• Tim_WMDE set the point value for this task to 2.
Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-10-15 board.Oct 22 2018, 2:09 PM
• Tim_WMDE added a comment.Oct 22 2018, 3:05 PM

@Cirdan Thank you for bringing this up! I have fixed the issue and pushed a new version of the banner to the live servers. Apologies for letting this slip through our testing. Let me know if the issue persists or if something is still broken.

• Tim_WMDE removed • Tim_WMDE as the assignee of this task.Oct 22 2018, 4:20 PM
• Tim_WMDE moved this task from Doing to Done on the WMDE-FUN-Sprint-2018-10-15 board.
• Stefan_Schneider_WMDE closed this task as Resolved.Nov 5 2018, 11:02 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL