Page MenuHomePhabricator
Create Task
Maniphest T207540

"Login for $1 succeeded" should include IP information
Closed, ResolvedPublic
Actions

Description

2018-10-20 12:06:19 [W8saOQpAICoAABOw3bkAAADF] mw1321 enwikiquote 1.32.0-wmf.26 authentication INFO: Login for Miszatomic succeeded {"user":"Miszatomic"}

This should include IP information

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Include IP address in "Login for $1 succeeded" log entrymediawiki/coreREL1_31+3 -1
Include IP address in "Login for $1 succeeded" log entrymediawiki/coreREL1_32+2 -1
Include IP address in "Login for $1 succeeded" log entrymediawiki/coreREL1_27+3 -1
Include IP address in "Login for $1 succeeded" log entrymediawiki/coreREL1_30+3 -1
Include IP address in "Login for $1 succeeded" log entrymediawiki/coremaster+2 -1
Include IP address in "Login for $1 succeeded" log entrymediawiki/corewmf/1.32.0-wmf.26+2 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedLegoktmT207540 "Login for $1 succeeded" should include IP information

Event Timeline

Reedy created this task.Oct 20 2018, 12:13 PM
Reedy triaged this task as High priority.
Reedy created this object with visibility "Custom Policy".
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2018, 12:13 PM
Legoktm subscribed.Oct 20 2018, 12:35 PM

0001-SECURITY-Include-IP-address-in-Login-for-1-succeeded.patch1 KBDownload

Untested.

Reedy added a comment.Oct 20 2018, 12:42 PM
In T207540#4682491, @Legoktm wrote:

0001-SECURITY-Include-IP-address-in-Login-for-1-succeeded.patch1 KBDownload

Untested.

Guess it should be clientip to be consistent :)

Reedy added a comment.Oct 20 2018, 12:44 PM

Any objections for just putting this into gerrit?

Reedy closed this task as Resolved.Oct 20 2018, 5:20 PM
Reedy assigned this task to Legoktm.
Reedy changed the visibility from "Custom Policy" to "Public (No Login Required)".
• chasemp added a project: Security.Feb 10 2020, 10:54 PM
• chasemp removed a project: acl*security.Feb 20 2020, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits