Page MenuHomePhabricator
Create Task
Maniphest T207620

Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched)
Open, LowPublic
Actions

Description

<Krenair> Is VE/Parsoid supposed to normalise a gallery's attributes when changing contents of it? E.g. I removed an image from a gallery using VE and it reordered the attributes, removed the 'px' from widths/heights, and IIRC the visual diff showed up strange for widths/heights
<Krenair> okay so visual diff reflects the change of widths/heights from having 'px' to not having 'px'.
<Krenair> it also shows 'altText changed from null to ' for each of the remaining images in the gallery - I assume that means they changed from null to empty string behind the scenes?

Related Objects

Event Timeline

Krenair created this task.Oct 22 2018, 12:19 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 22 2018, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krenair added a comment.Oct 22 2018, 12:30 AM

(probably lowest priority given how minor this is but I thought I'd file it anyway)

matmarex renamed this task from Slightly strange behaviour around removing image from gallery using VE to Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched).Oct 23 2018, 5:09 AM
matmarex added a parent task: T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery.
matmarex subscribed.Nov 7 2018, 3:03 PM

(Actually, it looks like T206534 can be solved without doing this one, and this task looks like it would take some non-trivial refactoring.)

matmarex removed a parent task: T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery.Nov 7 2018, 3:03 PM
Esanders triaged this task as Low priority.Nov 15 2018, 1:45 PM
Esanders subscribed.

I'm not to concerned about this, if you touch the gallery then it won't be that surprising that attributes are normalised, so I wouldn't categorise this as a dirty diff.

matmarex mentioned this in T211895: Visual editor shouldn't add the File: prefix when missing in a gallery.Dec 14 2018, 12:02 AM
JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.May 7 2019, 3:45 PM
Thibaut120094 subscribed.Dec 29 2019, 12:53 PM
Arlolra mentioned this in T329662: Edited gallery captions are ignored unless gallery's data-mw is dropped.Mar 29 2023, 2:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits