Page MenuHomePhabricator

Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched)
Open, LowPublic

Description

<Krenair> Is VE/Parsoid supposed to normalise a gallery's attributes when changing contents of it? E.g. I removed an image from a gallery using VE and it reordered the attributes, removed the 'px' from widths/heights, and IIRC the visual diff showed up strange for widths/heights
<Krenair> okay so visual diff reflects the change of widths/heights from having 'px' to not having 'px'.
<Krenair> it also shows 'altText changed from null to ' for each of the remaining images in the gallery - I assume that means they changed from null to empty string behind the scenes?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

(probably lowest priority given how minor this is but I thought I'd file it anyway)

matmarex renamed this task from Slightly strange behaviour around removing image from gallery using VE to Slightly strange behaviour around removing image from gallery using VE (gallery dialog normalizes everything it touched).Oct 23 2018, 5:09 AM

(Actually, it looks like T206534 can be solved without doing this one, and this task looks like it would take some non-trivial refactoring.)

Esanders added a subscriber: Esanders.

I'm not to concerned about this, if you touch the gallery then it won't be that surprising that attributes are normalised, so I wouldn't categorise this as a dirty diff.