Page MenuHomePhabricator

WikibaseQualityConstraints and Wikibase CI Job shouldn't load WikibaseQuality
Closed, ResolvedPublic

Description

Tests such as SpecialConstraintReportTest are falsely passing because WikibaseQuality is still loaded on CI.

It should be removed once we're happy that the tests pass without it being loaded avoid breaking CI for people. It can be removed by editing zuul/parameter_functions.py from integration/config.

It should be tested first by running quibble locally without WikibaseQuality loaded.

Details

Related Gerrit Patches:

Event Timeline

Tarrow triaged this task as Medium priority.Oct 22 2018, 1:37 PM
Tarrow created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2018, 1:37 PM

Change 469181 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[integration/config@master] Remove WikibaseQuality from Wikibase, WikibaseQualityConstraints

https://gerrit.wikimedia.org/r/469181

docker run -it --rm -e "ZUUL_PROJECT=mediawiki/extensions/WikibaseQualityConstraints" -e "EXT_DEPENDENCIES=mediawiki/extensions/BetaFeatures\nmediawiki/extensions/Capiunto\nmediawiki/extensions/CentralAuth\nmediawiki/extensions/CirrusSearch\nmediawiki/extensions/Cite\nmediawiki/extensions/Echo\nmediawiki/extensions/EducationProgram\nmediawiki/extensions/Elastica\nmediawiki/extensions/EventLogging\nmediawiki/extensions/GeoData\nmediawiki/extensions/PdfHandler\nmediawiki/extensions/PropertySuggester\nmediawiki/extensions/Scribunto\nmediawiki/extensions/SiteMatrix\nmediawiki/extensions/SyntaxHighlight_GeSHi\nmediawiki/extensions/TimedMediaHandler\nmediawiki/extensions/UniversalLanguageSelector\nmediawiki/extensions/VisualEditor\nmediawiki/extensions/WikiEditor\nmediawiki/extensions/Wikibase\nmediawiki/extensions/WikibaseLexeme\nmediawiki/extensions/WikibaseMediaInfo\nmediawiki/extensions/WikibaseQualityConstraints\nmediawiki/extensions/WikimediaBadges\nmediawiki/extensions/cldr" docker-registry.wikimedia.org/releng/quibble-stretch-php70

The removal can be tested locally with the above command.

Change 469181 merged by jenkins-bot:
[integration/config@master] Remove WikibaseQuality from Wikibase, WikibaseQualityConstraints

https://gerrit.wikimedia.org/r/469181

Legoktm closed this task as Resolved.Oct 29 2018, 10:57 PM