Page MenuHomePhabricator

Autosave can be triggered for loaded drafts without user change
Closed, ResolvedPublic

Description

This was a bug before, which was fixed in T193161. However, due to a regression, when draft is loaded, save can happen without user edit.

Since this patch, when block or inline transclusion node is rendered, update event is emitted. That gets treated as section change, which triggers saving. In effect, this means if saved draft has any transclusion nodes, the saving will be triggered even without a change.

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterUse different event when transclusion node is rendered

Event Timeline

Pginer-WMF triaged this task as Medium priority.Oct 24 2018, 11:43 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

Change 473182 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Use different event when transclusion node is rendered

https://gerrit.wikimedia.org/r/473182

Change 473182 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use different event when transclusion node is rendered

https://gerrit.wikimedia.org/r/473182

Etonkovidova closed this task as Resolved.Nov 30 2018, 10:56 PM